search

SchemaPlus / schema_associations

ActiveRecord extension that automatically (DRY) creates associations based on the schema
Other
46 stars 8 forks source link

Rails 4 Support #9

Closed tovodeverett closed 11 years ago

tovodeverett commented 11 years ago

I think this should clean up the test suite for Rails 4, and I'm pretty comfortable with that code.

It also resolves https://github.com/lomba/schema_associations/issues/7 . I'm a hair nervous since I don't totally understand the changes between Rails 3 and Rails 4 that resulted in the issue and I don't fully understand the code in question, but the change passed against the existing test suite without any issues.

I think my nervousness is more about whether there may be issues if the include for the scope specifies a model that has a default scope that specifies includes for the included model, but this is more of a vague idea.

tovodeverett commented 11 years ago

It looks like the presence of gemfiles/Gemfile.rails-3.2.lock is potentially interfering with the Travis tests, but since I'm operating beyond my paygrade I'm not sure if wiping it out is the best move.

ronen commented 11 years ago

you're right the .lock file shouldn't be there. .gitignore should be catching all the lock files, that one must have snuck in there before .gitignore was set up or some such. i'l take it out

ronen commented 11 years ago

released version 1.2.0