Closed hcarver closed 9 years ago
coveralls
commented
9 years ago Coverage remained the same at 100.0% when pulling fd02c223c09f36b408730664b8f2fbf75ad67030 on hcarver:allow_replace_with_views into 5be4f139a41d1287181afcbe4ba2f3e02efc6528 on SchemaPlus:master.
ronen
commented
9 years ago @hcarver cool looks good. Only one thing i might add to the doc is something along the lines of "subject to the some limitations; see the MySQL and PostgreSQL docs for details". But no need to make you go back again, i'll just merge and then edit it myself.
The instructions for setting up a dev environment didn't work for me
Bummer. What didn't work?
so I'm just crossing my fingers that the test passes!
It does!
ronen
commented
9 years ago Actually I noticed that :force wasn't documented at all! So I added documentation for both it and :allow_replace in the "Creating Views" section (moved your doc over).
I've release version 0.2.0 with this in it. Thanks for your contribution!
hcarver
commented
9 years ago No problem!
I couldn't find a single set of instructions to follow, but I eventually realised I needed ruby 2.1.5, and to install the schema_dev gem (it wasn't installing under ruby 2.0.0, which is probably not a problem if development is intended to only be done on 2.1.5).
I can't remember exactly what the next error I had was, but I think it was around creating the databases needed.
ronen
commented
9 years ago I eventually realized I needed... to install the schema_dev gem.
OK, yeah, that should be clearer. And the README over there should give better setup instructions. I've added an issue SchemaPlus/schema_dev#9
Refactored as you suggested, added some documentation and tests. The instructions for setting up a dev environment didn't work for me, so I'm just crossing my fingers that the test passes!