search

SchemaPlus / schema_validations

Automatically creates validations basing on the database schema.
Other
174 stars 34 forks source link

Make the gem work if ActiveRecord logger is nil #47

Closed gamecreature closed 8 years ago

gamecreature commented 8 years ago

I don't know exactly why but in our environment (under delayed job) the logger is nil at the moment of this debug call.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 10cb7fe1c541d7381ab2a0f492cfbdbb0ccd42c6 on gamecreature:master into 83ba3ab4afd7996ae33dfc86f054908b24f0c3c4 on SchemaPlus:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 10cb7fe1c541d7381ab2a0f492cfbdbb0ccd42c6 on gamecreature:master into 83ba3ab4afd7996ae33dfc86f054908b24f0c3c4 on SchemaPlus:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 10cb7fe1c541d7381ab2a0f492cfbdbb0ccd42c6 on gamecreature:master into 83ba3ab4afd7996ae33dfc86f054908b24f0c3c4 on SchemaPlus:master.

ronen commented 8 years ago

Thanks. Normally I'd request a spec with any bug fix but this does seem minor enough to just sneak in.

ronen commented 8 years ago

FYI this is included in release 2.2.0

gamecreature commented 8 years ago

Thanks!!