SchemaStore / schemastore

A collection of JSON schema files including full API
http://schemastore.org
Apache License 2.0
2.97k stars 1.61k forks source link

`catalog.json` is ambiguous for `.github/ISSUE_TEMPLATE/config.yml` #2364

Open alexrp opened 2 years ago

alexrp commented 2 years ago

Area with issue?

Web server

✔️ Expected Behavior

The GitHub issue forms schema entry in catalog.json should not match .github/ISSUE_TEMPLATE/config.yml.

❌ Actual Behavior

The GitHub issue forms schema in catalog.json matches .github/ISSUE_TEMPLATE/*.yml, which necessarily includes .github/ISSUE_TEMPLATE/config.yml, which is also matched by GitHub Issue Template configuration.

YAML or JSON file that does not work.

Any valid .github/ISSUE_TEMPLATE/config.yml, e.g.:

# yaml-language-server: $schema=https://json.schemastore.org/github-issue-config.json
blank_issues_enabled: false

IDE or code editor.

Visual Studio Code

Are you making a PR for this?

No, someone else must create the PR.

alexrp commented 2 years ago

I picked "no" for the PR question because I have no idea if this is actually a bug here or in the YAML language server, and in either case, I'm not sure what the proper fix even is. My immediate thought was an exclusion on the file matchers for GitHub issue forms but it doesn't seem like that's an actual feature in catalog.json...

yihongang commented 1 year ago

related issue: https://github.com/redhat-developer/yaml-language-server/issues/422#issuecomment-1129868430