SchemaStore / schemastore

A collection of JSON schema files including full API
http://schemastore.org
Apache License 2.0
3.11k stars 1.72k forks source link

Add Plex Prerolls config schema to catalog #4222

Closed nwithan8 closed 5 days ago

nwithan8 commented 6 days ago

Add externally-hosted schema for Plex Prerolls configuration files

github-actions[bot] commented 6 days ago

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

hyperupcall commented 5 days ago

Thanks! Would it be possible to update the fileMatch to something less generic? config.ya?ml is too generic and is likely to create false positives

nwithan8 commented 5 days ago

Thanks! Would it be possible to update the fileMatch to something less generic? config.ya?ml is too generic and is likely to create false positives

Yeah, I was concerned about that. I guess technically it would be a config.ya?ml file inside a config directory, if that helps narrow it down. Or I can remove the fileMatch pattern altogether to avoid this auto-applying to a different file.

hyperupcall commented 5 days ago

I think config/config.ya?ml is still a too generic so perhaps setting it to an empty array is the best idea

hyperupcall commented 5 days ago

Thanks