SchemaStore / schemastore

A collection of JSON schema files including full API
http://schemastore.org
Apache License 2.0
3.11k stars 1.72k forks source link

Add pnpm-workspace.yaml schema #4235

Open danielbayley opened 4 days ago

danielbayley commented 4 days ago

For example:

# https://pnpm.io/pnpm-workspace_yaml
$schema: https://json.schemastore.org/pnpm-workspace.json
packages:
  - packages/*

catalog:
  chalk: ^4.1.2

# https://pnpm.io/catalogs
catalogs:
  react16:
    react: ^16.7.0
    react-dom: ^16.7.0
  react17:
    react: ^17.10.0
    react-dom: ^17.10.0

Depends on #4233, and #4234.

[!NOTE] For reference, better linting, and composability, I have built my own collection of schemas here: https://github.com/danielbayley/schemas

github-actions[bot] commented 4 days ago

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

hyperupcall commented 18 hours ago

Thanks! I'll be able to merge this once all the tests pass. I would recommend replacing the "$ref": "https://json.schemastore.org/npm-semver.json"-type statements with { "type": "string" } (possibly with minlength set to 1) since they didn't quite get merged

danielbayley commented 3 hours ago

@hyperupcall Updated…