SchildiChat / SchildiChat-android

Matrix client / Element Android fork
https://schildi.chat/android/
Apache License 2.0
386 stars 50 forks source link

Emoji keyboard doesn't follow system emoji font #103

Open github-tomster opened 2 years ago

github-tomster commented 2 years ago

Is your feature request related to a problem? Please describe. on my device there is a file called NotoColorEmoji.ttf so far, all apps on my device showing emojis from this exact file. also schildichat shows them. this i call consistent. if i enable the function: 'show emoji keyboard' schilichat displays a button on the textinput with an emoji one can press. on pressing this button, some weird, [and imho ugly] emojis are displayed 😞

Describe the solution you'd like show/display the devices NotoColorEmoji.ttf ones‼️

Describe alternatives you've considered disable the emoji keyboard!

Additional context unfortunately this shows what a big mess the emoji topic is. once there was the NotoColorEmoji.ttf and period. then came the devs, embedding their own fugly emojis into the apps, and at last noodle with the https://developer.android.com/reference/androidx/emoji/text/EmojiCompat dictation. 🤦🏻‍♂️

to my knowledge there is one app: https://codeberg.org/kriztan/blabber.im that is coded to let the user choose:

if there is no will or skill to consider this, at least can one show where to hack the code to replace the embedded emoji with my desired NotoColorEmoji.ttf!

SpiritCroc commented 2 years ago

The emoji keyboard is a library, and unfortunately doesn't allow to use the system emojis, which I find annoying as well. At least I didn't find an obvious way to make the library do it without too much effort last time I checked.

You can disable the emoji keyboard in Settings / Preferences / Show emoji keyboard. Most soft-keyboards have an inbuilt emoji picker, you can use that one instead.

github-tomster commented 2 years ago

@SpiritCroc hm...

can at least this library be hacked to swap this wrong and false displayed emojis? where is the very source of this error made by the ones ignoring the system settings of the device?

SpiritCroc commented 2 years ago

It's open source, there's probably a cleaner solution than "hacking".

Friendly advice: while this issue seems to be important for you, it is not for me. So harsh words don't help to motivate me to even look at your issue (I'm working on this app in my free time as hobby, so I'm free to focus on what's important to me). I see that your harsh words go against the emoji keyboard and not against me, but let's be a little nicer either way, ok? :)

github-tomster commented 2 years ago

@SpiritCroc to fix the error made by others by whatever reason[no interest, no knowledge, no skill], i can only try to fix it by myself. i read your nice text that the code is not yours and you are not able to point me to the resource to hack/swap? or maybe silly me was to harsh and you wont help a pest like me? and what a pity you have to add faulty code to your project 😭

peace love and harmony! in favour of all those faulty beings i altered my words to describe the reality. 🕊️

i am very proud to be the first idiot recognizing this failing code! 😀 should i feel happy or sad 🤷🏻‍♂️ out of curiosity: may i ask you as dev, is it up-to-date to code such errors? and i get you: i do this in my free time too. 😹

SpiritCroc commented 2 years ago

I think the reason it got in the app as is is following:

I don't consider this "faulty", "failing code" or an "error", but rather a compromise. Compromises need to be done every now and then if you have limited resources. But you are of course free to look into fixing this yourself and contributing, that is the beauty of open source :)

As starting point for your own investigation, I can point you to these changes that added the emoji keyboard to the app, and to the vanniktech emoji library, which is the library in use.

github-tomster commented 2 years ago

@SpiritCroc thank you for your points to the library!

if one looks very closely the pure un-beauty is revealed on the emojis-on-android topic. 💢 how was it possible to evolve that way?

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 14 days.