Closed scytaleim closed 2 years ago
SpiritCroc
commented
2 years ago Thanks! I'll wait a little to see what upstream says to https://github.com/vector-im/element-android/pull/4984, since I'm not familiar with that code right now and don't have a quick way to test this right now. Also, who is the original author of this? I'm a little confused right now since this PR seems to include the same code changes like the upstream one, but the commit message and author are different.
scytaleim
commented
2 years ago Thanks! I'll wait a little to see what upstream says to vector-im#4984, since I'm not familiar with that code right now and don't have a quick way to test this right now. Also, who is the original author of this? I'm a little confused right now since this PR seems to include the same code changes like the upstream one, but the commit message and author are different.
Fine, achengfloyd is also me. I forked your repo cause i also want the the function gif autopaly in your repo, it does not exist in element-android. I'm a newbie of github, i tried to make a pull request to element-android from the repo that i forked from yours, but it commit a lot of files ~~. So i use the account achengfloyd to fork from element-android and made the change to that fork too. Then i made a pull request from that fork to element-android.
SpiritCroc
commented
2 years ago Ah, I see. Yeah, there would be more elegant ways, but should work this way too.
Fix a saclar token is needed by self deployed dimension when using sticker picker Fix roomid check is no needed when using sticker picker Noted: there still problem to enable sticker picker for the first time, if we want to use sticker picker, we should enable it on element-web then we can use sticker picker in android with self deployed dimension
After fix: