SchildiChat / SchildiChat-android

Matrix client / Element Android fork
https://schildi.chat/android/
Apache License 2.0
386 stars 50 forks source link

Code elements unreadable with the SC dark themes #116

Closed AlbanBedel closed 2 years ago

AlbanBedel commented 2 years ago

Describe the bug Using either of the SC dark/black themes all the code elements in message are just a grey block without text. Well most probably the text and background are in the same color.

To Reproduce Steps to reproduce the behavior:

  1. Have your phone in dark mode
  2. Select 'SC Dark' or 'SC Black' as dark theme
  3. Look for a message with a code element.
  4. Code element look empty.

Expected behavior Code elements should always be readable.

Smartphone:

Additional context

Upstream relevance I assume the 'SC' themes are specific to SchildiChat. There is also a similar bug with the 'Element Black' theme that also make the user pills unreadable.

SpiritCroc commented 2 years ago

Looks fine here: device-2022-03-15-194811

Can you test following:

AlbanBedel commented 2 years ago

It is the same with the beta version: Screenshot_2022-03-15-22-34-19-732_de spiritcroc riotx testing foss

SpiritCroc commented 2 years ago

Hm. There are multiple colors in that screenshot that look off. Could there be some operating system - wide theming solution messing with the app?

AlbanBedel commented 2 years ago

The screenshot was with "SC Dark, colored bubbles" and the phone set to dark mode. If I set my phone to light mode and chose the "SC Dark" theme it then look like your screenshot where the code blocks have a black background. It seems my OS is messing with black backgrounds when in dark mode.

SpiritCroc commented 2 years ago

Yes, that seems to be the case. Some OSes have an option to "force dark theme", maybe you can check if you have such thing enabled.