search

SchildiChat / SchildiChat-android

Matrix client / Element Android fork
https://schildi.chat/android/
Apache License 2.0
386 stars 49 forks source link

Schildi Light theme has a black navigation bar #149

Closed BubuOT closed 1 year ago

BubuOT commented 1 year ago

Describe the bug The element light theme comes with a light-coloured navigation bar. The schildi variant of that theme has a black navigation bar, which looks a bit out of place on a modern android phone for a light-mode theme.

To Reproduce Steps to reproduce the behavior:

  1. Select schildi Light theme from preferences

Expected behavior Have the navigation bar coloured like the status bar.

Screenshots Note the bottom edge of the screenshots. (This is gesture navigation mode, which is why the bar is so small.)

Element Theme Schildi Theme
image image

Smartphone (please complete the following information):

Additional context

Upstream relevance

SpiritCroc commented 1 year ago

Should be fixed with https://github.com/SchildiChat/SchildiChat-android/commit/b777c4bf03badaad6f508e78bf69478b2abdd4cf

BubuOT commented 1 year ago

Oops, I guess I should have known you are faster with fixing this than I am to report this issue. :sweat_smile:

SpiritCroc commented 1 year ago

Haha. I was already preparing some builds with Element's new layout working, and your report made me realize that it's even more important there, since the new app layout enforces a white bar apparently, leading to white icons on white background otherwise :joy: