SchildiChat / SchildiChat-android

Matrix client / Element Android fork
https://schildi.chat/android/
Apache License 2.0
386 stars 49 forks source link

add split screen support #171

Open Sinofine opened 1 year ago

Sinofine commented 1 year ago

With android's multi windows support, it's easy to split two activities into two windows, which benefits tablet users.

Screen shots:

Screenshot_20230112_163144_SchildiChat dbg Screenshot_20230112_163343_SchildiChat dbg

also I provided multi chat windows option for windowed mode android (like samsung's DeX mode)

Screenshot_20230112_180024_One UI Home

Those options are opt-in by default for compatibility.

Screenshot_20230112_180112_One UI Home

reference: https://developer.android.com/guide/topics/large-screens/multi-window-support

SpiritCroc commented 1 year ago

Wow, that looks great! I'll try to test it in the coming weeks.

SpiritCroc commented 1 year ago

Just did some testing, initial thoughts:

Don't know what to expect from non-tablets, but if I enable tablet mode on my Android 11 phone and do the following:

Then it gets me to my launcher instead back to the room list. After that, whenever I re-open the app from recents, I get a blank screen, and I need to close the app with back or by killing it to get it working again by starting it from launcher. The multiwindow setting doesn't make a difference for that matter. Since you put the feature in labs, that's probably not a blocker, but it would be nice to have some narrower device requirements to detect if the feature will be useful on the particular device, and hide and force-disable it if that's not the case.

On my Android 11 tablet, it behaves the same as with my phone. Could it be a problem of my custom ROM not being configured properly to support these features, or is Android 11 too old? On a foldable emulator with Android 13, split screen works, but I haven't gotten the windowed mode to work, is there a system setting that I need to enable?

Sinofine commented 1 year ago

I've tested the feature on my samsung tab s7 with android 13, it works flawlessly; however using my phone (MIUI13, an custom ROM with android 12 inside) it doesn't work well (as multiple windows are not well supported on phone devices). Thus I might think that it's well to hide it in phone devices.

Furthermore, I'll test the feature with some more tablet devices, as in google's guide there are not major changes done after android 10.

Sinofine commented 1 year ago

Screenshot_20230210_092842_SchildiChat dbg

my recent works.

ThatOneCalculator commented 1 year ago

Any update on this?

Sinofine commented 1 year ago

Any update on this?

recently I'm working on this approach

seems that google thinks it's better than multi window approach.