SchildiChat / SchildiChat-android

Matrix client / Element Android fork
https://schildi.chat/android/
Apache License 2.0
386 stars 49 forks source link

activity embedding (android 12L) #179

Open Sinofine opened 1 year ago

Sinofine commented 1 year ago

https://user-images.githubusercontent.com/47494321/221361280-696d5958-96af-46e9-b3b6-648dad83de7d.mp4

mobile view (it doesnot affect small screens)

https://user-images.githubusercontent.com/47494321/221362233-13ae83f0-61cf-4112-9011-7c3764b19f76.mp4

SpiritCroc commented 1 year ago

Thank you! On first glance looks great on emulator (my real tablet is still only A11...) :+1:

Note to self: code resembles what's described here, so seems good: https://developer.android.com/guide/topics/large-screens/activity-embedding

Android Studio tells me there is a more recent -alpha06 for androirdx.window, though it doesn't compile as is when bumping the version, maybe some API changed? :thinking:

Would it be hard to hide behind a feature flag? Testing on foldable emulator, I got duplicate "please verify" banners, and the navigation drawer is larger than the left activity, thus being cut when expanded. Both not too bad if we can make this a labs setting - otherwise dunno, maybe worth having a while in beta to detect and fix anything before getting it into a stable release.

SpiritCroc commented 1 year ago

Oh, just wanted to test logging in, but noticed I can't even log out with this one, dialog is cut as well :/

Screenshot_2023-03-04_15-39-55

Sinofine commented 1 year ago

maybe it's better to add width of the left panel. The alpha06 version introduced several interface changes to the activity embedding.

when the device is wide enough, the logout dialog is okay. Screenshot_20230304_235618_SchildiChat dbg