search

SchildiChat / SchildiChat-android

Matrix client / Element Android fork
https://schildi.chat/android/
Apache License 2.0
385 stars 49 forks source link

Minor issues in Element Dark Theme #213

Open kefiiris opened 7 months ago

kefiiris commented 7 months ago

In the Element Dark Theme, I have observed 5 issues that make the design a bit non uniform. These issues are not present on Element itself. In element black, issue 1, 3 and 5 are present. In element light, all issues except 1 are present. 2, 3 and 4 are less prominent due to only slight colour difference.

  1. The unread counter is close to invisible. Screenshot_2023-11-13-11-10-23-977_de.spiritcroc.riotx.png

  2. There is a black line between the Navigation bar and the bottom of the app. Screenshot_2023-11-13-11-10-41-291_de.spiritcroc.riotx.png

  3. The colors of the statusbar and the titlebar of a room do not match. Screenshot_2023-11-13-11-11-03-834_de.spiritcroc.riotx.png

  4. The colors of the navigation bar and the backdrop of the chat area do not match. Screenshot_2023-11-13-11-11-18-526_de.spiritcroc.riotx.png

  5. There are 2 element-style cyan coloured bars on the first loading page of the app. Screenshot_2023-11-13-11-11-35-529_de.spiritcroc.riotx.jpg

SpiritCroc commented 7 months ago

I don't really recommend using the Element theme since it's largely untested from my side - the settings is just there because it didn't hurt to keep it in. I'm open to contributions if anybody wants to take care of these issues though, if their changes don't cause merge conflicts (i.e., do not mess with any upstream theming but only touch downstream modifications).