SchildiChat / SchildiChat-android

Matrix client / Element Android fork
https://schildi.chat/android/
Apache License 2.0
385 stars 49 forks source link

Duplicate "Settings" button #220

Closed foxyseta closed 6 months ago

foxyseta commented 6 months ago

Describe the bug The "Settings" menu can be opened by touching the user's propic at the top left of the main screen. So the "Settings" entry in the top right menu is redundant

Expected behavior There should be no "Settings" entry in the top right menu.

Smartphone (please complete the following information):

Additional context

Upstream relevance

SpiritCroc commented 6 months ago

This is on purpose. Opening settings by clicking on the profile picture is not intuitive to me and some other users, so having it in the menu can be seen as an accessibility feature. I'd rather remove the functionality from the profile picture, but then people switching from Element could get confused. Having multiple ways to reach settings doesn't really hurt, especially since the clicking-on-the-profile thing is not apparent by text or icon, so anyone can use the button which they prefer.