SchildiChat / SchildiChat-android

Matrix client / Element Android fork
https://schildi.chat/android/
Apache License 2.0
385 stars 49 forks source link

Long click on a message is triggered too fast #237

Open chagai95 opened 2 months ago

chagai95 commented 2 months ago

Describe the bug Sometimes when scrolling up the menu of a message is triggered because the long press is detected. Sometimes even twice because it's so easy to trigger.

To Reproduce https://youtu.be/y7KJKJCIBEo?si=wymTFVpz5hMFhGKL

Expected behavior set the time to a few more milliseconds before triggering the opening of the menu

Screenshots If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

Additional context

Upstream relevance

Add any other context about the problem here.

chagai95 commented 1 month ago

@SpiritCroc this is not happening on element, is this perhaps related to an older version of upstream? Or is the newest release merged? Can I somehow help take a look at this? Could you point me to the approximate location in the code? I've been fighting with this for weeks now and it's extremely annoying...

SpiritCroc commented 1 month ago

We're up-to-date on upstream merges. Not sure where to look for this, looks like some longpress listener getting touch events when it shouldn't since the list is scrolling, but no idea which of Schildi's changes would affects that. Being able to reproduce on a version where you can add debugging statements yourself while seeing what happens sounds like a good starting point, if that is in your skillset.