SchildiChat / SchildiChat-android

Matrix client / Element Android fork
https://schildi.chat/android/
Apache License 2.0
387 stars 51 forks source link

RTL Bubble Layout Jankiness #61

Closed anaskaejdar closed 3 years ago

anaskaejdar commented 3 years ago

Describe the bug If the app is set in an RTL language, such as Farsi or Arabic, some parts of the UI become clunkier. I'm talking about missing padding, timestamps always being on a new line. I've only noticed those two things so far.

To Reproduce Steps to reproduce the behavior:

  1. Put app in farsi
  2. Go into a chat
  3. Look at the padding on your own messages
  4. Look at the timestamps on all the messages

Expected behavior Timestamps should be on the same line as the message, given that it can fit, but it's instead being put on its own new line. It's worth noting that actually the timestamp gets rendered perfectly well if the message itself is written in an RTL language.

Screenshots Message in farsi, with an immaculate timestamp: Screenshot_۲۰۲۱۰۵۱۶-۱۹۵۷۱۷_SchildiChat

Messages in english. Notice the padding on the left side too: Screenshot_۲۰۲۱۰۵۱۶-۲۰۰۰۰۹_SchildiChat

same messages if app is in a LTR language: Screenshot_۲۰۲۱۰۵۱۶-۲۰۰۰۵۱_SchildiChat

Smartphone (please complete the following information):

Additional context

Upstream relevance

Add any other context about the problem here.

Álo 👋🏼

SpiritCroc commented 3 years ago

Thanks for reporting! Those issues will be addressed in the next release. If you notice issues in the next release as well, feel free to open a new issue or re-open this one.

anaskaejdar commented 3 years ago

@SpiritCroc Thank you, man. It came into fdroid a couple days ago, and it looks great. There is one other layout bug I found. Here, take a look:

RTL:

Screenshot_۲۰۲۱۰۶۰۱-۱۷۰۷۰۴_SchildiChat Screenshot_۲۰۲۱۰۶۰۱-۱۷۱۲۱۰_SchildiChat

LTR:

Screenshot_۲۰۲۱۰۶۰۱-۱۷۰۷۴۳_SchildiChat Screenshot_۲۰۲۱۰۶۰۱-۱۷۱۳۳۷_SchildiChat

Obviously the first one is caused by that long username pill. No such pill on the second one though.