search

SchildiChat / SchildiChat-android

Matrix client / Element Android fork
https://schildi.chat/android/
Apache License 2.0
387 stars 51 forks source link

Another RTL Margin Bug #66

Closed anaskaejdar closed 3 years ago

anaskaejdar commented 3 years ago

I originally made this as a response to a different issue, a closed one I made before. I couldn't reopen the issue, though, I think I don't have the necessary privs. Feel free to close this and open that: https://github.com/SchildiChat/SchildiChat-android/issues/61#

RTL:

Screenshot_۲۰۲۱۰۶۰۱-۱۷۰۷۰۴_SchildiChat Screenshot_۲۰۲۱۰۶۰۱-۱۷۱۲۱۰_SchildiChat

LTR:

Screenshot_۲۰۲۱۰۶۰۱-۱۷۰۷۴۳_SchildiChat Screenshot_۲۰۲۱۰۶۰۱-۱۷۱۳۳۷_SchildiChat

Obviously the first one is caused by that long username pill. No such pill on the second one though.

Originally posted by @maemunman in https://github.com/SchildiChat/SchildiChat-android/issues/61#issuecomment-852585873

SpiritCroc commented 3 years ago

I was able to reproduce the long pills issue, but not the other one, not sure why. Either way, please test and report if it's better once 1.1.8 is out.

anaskaejdar commented 3 years ago

The second one only happens on certain messages. I don't know what the pattern is. You may find it if you scroll back far enough in a room though.

anaskaejdar commented 3 years ago

I haven,t encountered it in a while, I think maybe it's fixed