search

SchildiChat / SchildiChat-android

Matrix client / Element Android fork
https://schildi.chat/android/
Apache License 2.0
386 stars 51 forks source link

Rejecting an invite doesn't make it disappear #83

Closed phesch closed 11 months ago

phesch commented 2 years ago

Describe the bug Sometimes(?), rejecting an invite doesn't cause that invite to go away from the main screen. The rejection was definitely sent, because checking with another client (Element Desktop) doesn't show it anymore. Selecting "Reject" again just makes the spinner reappear until navigating somewhere else. Coming back will show the buttons again. Performing an initial sync will make the invite disappear.

To Reproduce Steps to reproduce the behavior:

  1. Get an invite (to a DM in this case).
  2. Select "Reject" on the main screen.
  3. The spinner appears, but the invite doesn't go away.
  4. Coming back later still shows the invite.

Expected behavior After selecting "Reject", the invite should go away after a brief period of time.

Smartphone (please complete the following information):

Additional context

Upstream relevance

darkmorpher commented 1 year ago

Is this still reproducible on current release v1.4.34.sc58 ?

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 14 days.

phesch commented 1 year ago

Sorry it took me so long to get back to you - the notification for your comment got lost in my inbox :/

I just checked by creating a new room with a secondary account and inviting my first account to it, then rejecting that invite from SchildiChat. It shows the same behavior as described in my original report. I tested this on version v1.5.8.sc62, which is the version currently available on F-Droid.

phesch commented 1 year ago

I was just checking my server's proxy access logs when I noticed the following line (logged at the time I performed the test):

<IP> - - [<TIME>] "GET /_matrix/client/r0/rooms/!<ROOM_ID>:matrix.org/members?at=1051519&not_membership=LEAVE HTTP/1.1" 403 114 "-" "SchildiChat/1.5.8.sc62 (LGE LM-G810; Android 12; SKQ1.211103.001; Flavour GooglePlay; MatrixAndroidSdk2 1.5.8)" "-" 582 0.015

Maybe this could be a hint as to the cause?

SpiritCroc commented 1 year ago

Latest stable release is quite old, maybe worth trying again once we'll get a new release in the coming days (I hope). Either way, I haven't really touched any related code as far as I'm aware, so it's likely either an Element issue or a conduit issue.

github-actions[bot] commented 11 months ago

This issue is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 14 days.