SchildiChat / SchildiChat-android

Matrix client / Element Android fork
https://schildi.chat/android/
Apache License 2.0
386 stars 50 forks source link

accent colour is used incorrectly in some places (online indicator, verification shield color) #97

Closed Bubu closed 2 years ago

Bubu commented 2 years ago

Describe the bug if you set red as your accent colour, contacts that are online will be shown with a red dot. similarly a red shield now means "verified". :see_no_evil:

This is also tricky with the default color, as the verification shield in element has a different green colour but it explicitly ask you that both shields look the same... which has created some user-confusion in the past.

To Reproduce Steps to reproduce the behavior:

Expected behavior certain elements retain their default colours.

Screenshots

Smartphone (please complete the following information):

Additional context

Upstream relevance

SpiritCroc commented 2 years ago

I guess we should probably use the Schildi-default-green for verification across all SC themes, so it at least matches Schildi-Desktop (no, I don't want to use Element green anywhere for the Schildi themes).

For the presence indicator, I don't think it's much of an issue... if you choose red as accent color, you surely want red to be more than just a color for warnings, don't you?

Bubu commented 2 years ago

I guess we should probably use the Schildi-default-green for verification across all SC themes, so it at least matches Schildi-Desktop (no, I don't want to use Element green anywhere for the Schildi themes).

I think that's fair.

For the presence indicator, I don't think it's much of an issue... if you choose red as accent color, you surely want red to be more than just a color for warnings, don't you?

I honestly don't know. On the one hand... yes, it kind of fits the theming. On the other hand it is quite confusing I think. Red status indicator immediately says BUSY! to me :man_shrugging:. Maybe doing some testing with this would help figuring this out.

SpiritCroc commented 2 years ago

I honestly don't know. On the one hand... yes, it kind of fits the theming. On the other hand it is quite confusing I think. Red status indicator immediately says BUSY! to me man_shrugging. Maybe doing some testing with this would help figuring this out.

Hm, I see your point. Would you suggest using the SC green for presence in all SC themes, or only in the red theme?

Bubu commented 2 years ago

All yellow-ish, orange-ish and reddish accent colours will clash with some preconceived status notion. (yellow/orange -> away).

The blue-ish and purple ones are likely fine. It might still be a bit confusing what a purple status is supposed to mean, but at least I wouldn't know what else this could be confused with.

Edit: After trying out purple for a bit, I think that this looks fine as is :-).

fynngodau commented 2 years ago

I think this would be a good solution: all of the five colors in the first color selection row, plus maybe the last Lava color, seem unfit to be used as an „available” status indicator. For all other colors it is slightly confusing at first, but ultimately fits the theme better.