SchildiChat / SchildiChat-android

Matrix client / Element Android fork
https://schildi.chat/android/
Apache License 2.0
386 stars 50 forks source link

Successful verifications aren't stored (shield stays black) #98

Closed jaller94 closed 1 year ago

jaller94 commented 2 years ago

Describe the bug Even after successfully verifying a person, their verification shield stays black.

To Reproduce Steps to reproduce the behavior:

  1. Verify a user.

I tested when

All variations of this verification flow seem to be affected.

Navigating out of the chat and back into it does not make the shield turn green. Clearing the cache of SchildiChat does not make the shield turn green.

Expected behavior The other person is now successfully verified and a green shield shows up next to their Display Name.

Smartphone (please complete the following information):

Additional context

Upstream relevance

SpiritCroc commented 2 years ago
* The issue does not exist on Element Android.

I'd be surprised. Our logic should not differ to theirs. For example, https://github.com/vector-im/element-android/issues/1377 and https://github.com/vector-im/element-android/issues/3169 look similar.

jaller94 commented 2 years ago

Both linked issues seem to be about the verifying your own devices. This issue is about verifying other people.

On my Android phone I have the same account logged into SchildiChat and Element. Only with Element the verifications are persisted (= my device shows a green shield for their account).

SpiritCroc commented 2 years ago

I tried now following on some of my Schildi-Androids with base-version 1.3.6:

Both worked for marking each other as verified.

Are there any chances your SchildiChat and your Element Android differ in some cross-signing setup? I know this might be a little annoying to test, but it might be interesting too to compare a fresh install of SchildiChat with a fresh install of Android of the same Element-Android-version, just to be sure.

loomy commented 1 year ago

same here with android 11 and the fdroid version 1.4.20.sc55

shields in rooms are always black. they are not getting green nor red, whats even worse.

@SpiritCroc have you tested with the fdroid version ?

SpiritCroc commented 1 year ago

same here with android 11 and the fdroid version 1.4.20.sc55

shields in rooms are always black. they are not getting green nor red, whats even worse.

@SpiritCroc have you tested with the fdroid version ?

Yes, I'm almost always on fdroid versions these days. But that shouldn't make any difference for this matter either way.

loomy commented 1 year ago

ok. but seems to be a factor in our case. we are 3 users fresh set up of server and clients. 2 users are on fdroid schildi, one is on google play schildi. the google play user has green shields for users an chats. the two fdroid users have black shields.

SpiritCroc commented 1 year ago

I'd still assume the differences to be rather account-specific or login-specific (e.g. some broken secure backup or verification state), unless there's clear evidence that there's a difference in variants here (i.e. you can install the same version number with different variants repeatedly on the same device with the same account and same setup procedure and get reliably said difference).

jaller94 commented 1 year ago

It's 12 months old and I don't remember this coming up again. Closing as "can't reproduce".