Add notification highlight to included themes

SchildiChat / schildichat-desktop

Matrix client / Element Web/Desktop fork

https://schildi.chat

Apache License 2.0

371 stars 42 forks source link

Add notification highlight to included themes #141

Open BurnyBoi opened 1 year ago

BurnyBoi commented 1 year ago

The themes included with SchildiChat do not have the highlight around notification messages:

SchildiChat:

Element:

Adding the highlight back to the included themes would improve visibility of notifications significantly.

su-ex commented 1 year ago

Is this a direct chat or one with two users only by any chance? This should have gone only missing in that case and with our bubble layout, as I didn't yet figure out a nice visual way for that, but not for the other layouts. 🤔

BurnyBoi commented 1 year ago

This is in a room with more than 2 users. This same behavior happens for me in public rooms. Message Layout is set to Modern

DeskworkTrickster commented 1 year ago

My 2 cents on this topic, since I would also really like to see that in Schildi:

Non-Bubbles:

How Element does it makes quite a lot of sense in my opinion. The highlighting could be a bit stronger, for better visibility in my opinion though. Also a different color for dark and light theme would make sense I guess. Since finding a color that works equally good on both is hard.
Having the highlighting on mentions and replies and also in 1:1 chats or chat rooms or public rooms shouldn't make a difference. Mostly due to uniformity, but also since having highlighting for replies does also make sense in 1:1 chats and not only in big rooms.

Bubbles:

They seem to have no highlighting at all at the moment, which I guess is pretty annoying.
My suggestion for that: Make the text red (same concept as in the modern layout) and make the bubble a different color to highlight it. Like this it feels similar to the other layouts.

Looking forward to your thoughts.

SpiritCroc commented 1 year ago

Having the highlighting on mentions and replies and also in 1:1 chats or chat rooms or public rooms shouldn't make a difference. Mostly due to uniformity, but also since having highlighting for replies does also make sense in 1:1 chats and not only in big rooms.

I can't stand having highlighted text in DMs caused by message replies. Replying to a message in a DM doesn't make the message more important, but only serves for reference what you're talking about. For mentions, ok, I could accept highlighting these in DMs as well.

DeskworkTrickster commented 1 year ago

Since that's all personal preference I think, it would make sense to have text and background highlighting and then just have settings to enable or disable them.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 14 days.