SchildiChat / schildichat-desktop

Matrix client / Element Web/Desktop fork
https://schildi.chat
Apache License 2.0
370 stars 42 forks source link

Space Permission Settings Don't Protect Against Self-Changes #213

Closed Windows81 closed 3 months ago

Windows81 commented 8 months ago

Steps to reproduce

I use Schildi, though the steps are also reproduceable on Element itself:

  1. Navigate to a space's settings.

image

  1. Roles & Permissions » Priviledged Users

image

Outcome

What did you expect?

For an action that can potentially brick any space where the only admin is you, it's expected that there is a warning popup if you're modifying your own permission level.

What happened instead?

Your role changes right away. If the space had only one admin before, it now has zero admins. Under default settings, that'll essentially brick the entire space and prevent any metadata changes from ever emerging.

Operating system

Windows 11

Browser information

Ungoogled Chromium 117

URL for webapp

app.schildi.chat

Application version

SchildiChat version: 1.11.30-sc.2

Homeserver

matrix.org

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 14 days.