search

SchildiChat / schildichat-desktop

Matrix client / Element Web/Desktop fork
https://schildi.chat
Apache License 2.0
370 stars 42 forks source link

Custom emoji reactions per MXC URL #217

Open CrimsonFork opened 8 months ago

CrimsonFork commented 8 months ago

SC web 1.11.30-sc.2, reactions just show the cleartext. image

SpiritCroc commented 8 months ago

It's not "broken" as the matrix spec doesn't tell you that these should be rendered if they are matrix urls yet. So until the appropriate MSC is merged which proposed that MXC urls can be sent "custom" reactions, just rendering any text that there is is actually the "expected" behaviour. Rendering such reaction MXCs has actually been implemented in schildichat-desktop in https://github.com/SchildiChat/matrix-react-sdk/commits/image-reactions-sumner but hasn't found its way into a release yet.

CrimsonFork commented 7 months ago

Could've sworn it used to be in SC web before.

On Thu, 2 Nov 2023, 09:11 SpiritCroc @.***> wrote:

It's not "broken" as the matrix spec doesn't tell you that these should be rendered if they are matrix urls yet. So until the appropriate MSC is merged which proposed that MXC urls can be sent "custom" reactions, just rendering any text that there is is actually the "expected" behaviour. Rendering such reaction MXCs has actually been implemented in schildichat-desktop in https://github.com/SchildiChat/matrix-react-sdk/commits/image-reactions-sumner but hasn't found its way into a release yet.

— Reply to this email directly, view it on GitHub https://github.com/SchildiChat/schildichat-desktop/issues/217#issuecomment-1790254761, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFM522RB4PVTQFBX7YWUMY3YCNIS3AVCNFSM6AAAAAA6ZZ732OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQGI2TINZWGE . You are receiving this because you authored the thread.Message ID: @.***>

TruncatedDinoSour commented 4 months ago

+1