Schillings / SwordPhish

Schillings SwordPhish empowers organisations and engages its employees to establish the key component of any cyber security strategy: the Human Firewall.
https://cyber.schillingspartners.com
Apache License 2.0
107 stars 22 forks source link

A confirmation dialog for reports #6

Open znb opened 6 years ago

znb commented 6 years ago

Just some feedback from our user base.

We have had a few false positives being reported because people are clicking the wrong button. It would be handy to have a confirmation dialog pop up after clicking the submit button.

It's a nice to have for me, but users would probably celebrate.

eth0izzle commented 6 years ago

Sounds like a sensible suggestion. I’ll see what I can do.

Thanks for the feedback.

oded86w commented 6 years ago

Hi , I try the button and recived a few false positives also . I think that a confirmation dialog pop up it's good idea . And also maybe pin the button in the end of ribbon , because it's close to delete button . Thank you .

eth0izzle commented 6 years ago

@oded86w thanks for the feedback. Are you finding they are hitting the button accidentally or are reporting the wrong e-mails? i.e spam is being reported a phishing.

oded86w commented 6 years ago

I think from both cases . But the most is accidentally .

oded86w commented 6 years ago

I think it be nice to move the button to end . and maybe the logo is black and look similar to delete (X) .

eth0izzle commented 6 years ago

You can change the position of the button under "Options > Customize Ribbon", but I'm not sure how you deploy this. I'll add the option for a confirmation dialog.

oded86w commented 6 years ago

I know how to change in my outlook but change in few computer it's not comfortable . you can change in code in ribbon xml : insertBeforeMso="GroupMailDelete" and change it ?

"groupMailSwordPhish" insertAfterMso="GroupMailSearch" getLabel="GetGroupLabel"

"groupReadSwordPhish" insertAfterMso="GroupMailEdit" getLabel="GetGroupLabel"

I think it be nice :)

thomasbrewster commented 6 years ago

We had the same need so we added the following code to Ribbon.cs

        public void ReportMailItem(IRibbonControl control)
        {
            //added message box confirmation
            DialogResult confirmation = MessageBox.Show("Are you sure you would like to report this email as phishing?", "Phishing Report Confirmation", MessageBoxButtons.YesNo);
            if (confirmation == DialogResult.Yes)
            {
                Globals.ThisAddIn.SendReport(GetMailItemBasedOnControl(control));
                ribbon.InvalidateControl(control.Id);
            }
        }