[sync] re-introduce fall-back to IMDb if video is not contained in TMDB/TheTvDB

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Add a new movie or a new TV series to the filesystem.
2. Some files are missing coverart in the tmdb/thetvdb.
3. Run a sync.

What is the expected output?
All files for which a IMDB id is found should be added.

What do you see instead?
Only files with both an IMDB id found *and* also a match in tmdb/thetvdb with 
the same id are added.

What version of the product are you using?
1261

Please provide any additional information below.
There was a change added in -r1224. Part of the change added a number of early 
return None exits from syncWithId() in sync.py.
This causes the caller to see the None return, take it as an error, and not add 
anything to the database at all.

Cheers, Robert.

Original issue reported on code.google.com by rob...@manillusion.no on 30 Apr 2012 at 6:52

[GoogleCodeExporter]

Hi Robert,

thanks for the hint. I'm not quite sure yet about that 

  "broke adding anything with missing >>>coverart<<<"

since from my current point of view just missing Arts (as stated in the issue 
abstract) should not be a problem, but I will double-check that in order to be 
100% sure. 

But what I can confirm right now is that missing entries in TMDb / TheTvDB are 
handled as errors - that's true and differs from the original solution, where 
we additionally considered the fallback to IMDb in case the language of the 
plot retrieved from (for example) TheMovieDB differed from the configured sync 
language. 

I will drop the return statements in order to have the fallback back again... 
:-)

Can you please provide the names of some movies where you found that issue so I 
can use them as test cases?

TIA & Cheers, Erik

Original comment by erik.for...@gmail.com on 1 May 2012 at 7:37

• Changed state: Accepted

[GoogleCodeExporter]

Go to imdb.com, search for America's Next Top Model

This will reveals it's imdbid is tt0363307

This imdbid is not known by thetvdb.com

So adding episodes of America's Next Top Model fail.

Another example is The Punk Rock Movie from England

imdbid tt0207685

Not known in themoviedb

So also fails to get added

Any TV episode or movie with is found in imdb but not found in 
thetvd/themoviedb will fail as far as I can see.

Cheers, Robert.

Original comment by rob...@manillusion.no on 1 May 2012 at 9:35

[GoogleCodeExporter]

Hi Robert,

thanks for the info - I will try to check-in a new version ASAP.

One additional information: concerning "America's next topfmodel" the problem 
is actually the entry in thetvdb.com! The TV show is there as can be seen here:

http://thetvdb.com/?tab=series&id=71721

but it's simply missing the IMDb-ID! 

If you have a TheTvDB.com account you can check the properties of the TV show 
by clicking the "Show/hide edit" link and you'll find that the entry for 
IMDb-ID is empty. This can be fixed by simply adding the correct IMDb-ID and 
saving the show.

Thanks again & Cheers, Erik

Original comment by erik.for...@gmail.com on 1 May 2012 at 10:26

[GoogleCodeExporter]

Thanks for the superfast help!

I wasn't aware I could add an account on thetvdb and edit the missing/wrong 
information. Will do that in the future instead of adding valerie.info files to 
my local filesystem.

Cheers, Robert.

Original comment by rob...@manillusion.no on 1 May 2012 at 11:52

[GoogleCodeExporter]

Hi again,

you're welcome... You can sign-up for both TheMovieDB and TheTvDB in order to 
add for example missing movies / TV shows - or to correct already existing data 
or to enhance the databases with missing data (plot, Arts or even whole movies 
/ TV shows).

But if you make any changes it might take some hours or even "days" until the 
changes are available for PVMC through the used APIs!

So far for now - keep you posted regarding the fix...

Cheers, Erik

Original comment by erik.for...@gmail.com on 1 May 2012 at 3:56

• Changed title: [sync] re-introduce fall-back to IMDb if video is not contained in TMDB/TheTvDB
• Changed state: Started

[GoogleCodeExporter]

I'm not sure if one of my films run into this topic exactly, but i try to 
explain:

i have a move, "Aufschneider", exists in IMDb (IDs tt1657537 and tt1657538), 
theTVdb and in TMDB.
The problem is i didn't get the two movie parts in the PV DB, the scan didn’t 
find it nor the manual add in the WebIF work for this film. I told PV its a 
movie (because its in the movie folder) but IMDb say its a series with two 
episodes in one season ...

If i'm wrong with this topic, please delete this psot and i'll create new issue

Thanks
Urogutt

Original comment by Urog...@googlemail.com on 1 May 2012 at 6:26

[GoogleCodeExporter]

Hi Urogutt,

I just checked that "movie" and this seems to be a different problem: IMDb is 
the "master" and (as you already found out yourself) in the IMDb-database this 
video is stored TV show as can be seen here:

http://m.imdb.com/find?q=aufschneider

=> we will always detect this recording as "TV Show" and hence dismiss the 
result since we search for a movie (as indicated by your folder type!).

Perhaps there's a solution for that, but please open a new issue of type 
"Question" for that so we don'gt "spam" Robert with mails regarding this 
problem...  ;-)

Thanks & Cheers, Erik

Original comment by erik.for...@gmail.com on 1 May 2012 at 7:33

[GoogleCodeExporter]

Internal note:
Bringing back the IMDb-fallback is an easy thing - unfortunately testing the 
function of the local IMDb-Provider showed, that the result returned in the 
meantime by IMDb looks totally different from what PVMC currently expects.

So to make a long story short: the local imdb provider used as fallback if a 
movie is not found in TheMovieDb doesn't work right now. 

=> It needs to get evaluated how to bring the original functionality back by 
using the correct DIV tags...

Original comment by erik.for...@gmail.com on 2 May 2012 at 10:34

[GoogleCodeExporter]

Internal note:
Further tests revealed, that in some cases we still find the correct 
information - depending on the structure of the returned data.

Hence with this issue I will remove the "return None" statement so the local 
IMDb provider is used again. For the additional problems found with the 
IMDb-provider I will open a seperate issue with detailed use-cases showing the 
prolem...

Original comment by erik.for...@gmail.com on 7 May 2012 at 3:18