search

SchizoDuckie / DuckieTV

A web application built with AngularJS to track your favorite tv-shows with semi-automagic torrent integration
http://schizoduckie.github.io/DuckieTV/
Other
1.13k stars 273 forks source link

Slash (/) removed from series name, instead of replaced with blank #1174

Closed marcelpaulo closed 5 years ago

marcelpaulo commented 5 years ago

What build of DuckieTV are you using (Standlone / Chrome Extension (New Tab / Browser Action)) Standalone

What version of DuckieTV are you using (Stable 1.1.x / Nightly yyyymmddHHMM) Latest angular: 260d8494

What is your Operating System (Windows, Mac, Linux, Android) Ubuntu 18.02.02 LTS

Describe the problem you are having and steps to reproduce if available A slash / in a series name, e.g. What/If, is removed, WhatIf, instead of replaced with a space, which causes: no torrent is found for any episodes of the series, since the torrent names usually have the slash replaced with a dot. For instance, if I search for the pilot episode of season 1 of series What/If, here's what I get: image

In order to find the torrent, I have to manually insert a space between What and If: image

I have noticed that other punctuation marks are correctly replaced with a space.

As @garfield69 explained in #1077, there's a sceneNameExceptions table, but then every single show which includes a / would have to be added. As of right now, I'm bumping into 2 shows with this problem: Fosse/Vernon and What/If. Wouldn't it be the case of just replacing the / with a space, like it's done with other punctuation marks?

Attach any DuckieTV statistics or Developer Console logs if available

[
  {
    "name": "DuckieTV Web Based",
    "data": "1.1.6"
  },
  {
    "name": "Current Date and Time",
    "data": "Fri, 24 May 2019 21:40:43 GMT"
  },
  {
    "name": "NWJS, Chromium",
    "data": "0.31.3 , 67.0.3396.87"
  },
  {
    "name": "UserAgent",
    "data": "DuckieTV-Standalone v1.1.6 X11; Linux x86_64"
  },
  {
    "name": "Platform, Vendor",
    "data": "Linux x86_64, Google Inc."
  },
  {
    "name": "Screen (width x height)",
    "data": "1366 x 768"
  },
  {
    "name": "Default Search Engine",
    "data": "RarBG [Jackett] (Enabled)"
  },
  {
    "name": "Default Torrent Client",
    "data": "Transmission (Enabled and Connected to Host)"
  },
  {
    "name": "Auto Download Service",
    "data": "(Disabled)"
  },
  {
    "name": "Last checked TraktTV for DB updates on",
    "data": "Fri, 24 May 2019 05:38:05 GMT"
  },
  {
    "name": "User Preferences on Local Storage",
    "data": "{\n  \"ThePirateBay.mirror\": \"https://thepiratebay.org\",\n  \"application.language\": \"en_us\",\n  \"application.locale\": \"en_us\",\n  \"autobackup.period\": \"weekly\",\n  \"autodownload.delay\": 15,\n  \"autodownload.multiSE\": {\n    \"ThePirateBay\": true,\n    \"1337x\": true,\n    \"IsoHunt\": true,\n    \"KATcr\": true,\n    \"Nyaa\": true,\n    \"RarBG\": true,\n    \"ShowRSS\": true,\n    \"TorrentDownloads\": true,\n    \"TorrentZ2\": true,\n    \"Zooqle\": true,\n    \"EzTV.ag\": true,\n    \"Idope\": true,\n    \"LimeTorrents\": true,\n    \"SkyTorrents\": true,\n    \"ETTV\": true,\n    \"ETag\": true,\n    \"IsoHunt2\": true,\n    \"Demonoid\": true,\n    \"bj-share\": true,\n    \"BJ-Share\": true,\n    \"KickAssTorrent\": true,\n    \"TGx\": true\n  },\n  \"autodownload.multiSE.enabled\": false,\n  \"autodownload.period\": 1,\n  \"background-rotator.opacity\": \"0.4\",\n  \"calendar.mode\": \"date\",\n  \"calendar.show-downloaded\": true,\n  \"calendar.show-episode-numbers\": true,\n  \"calendar.show-specials\": false,\n  \"calendar.startSunday\": false,\n  \"client.determinedlocale\": \"en_us\",\n  \"download.ratings\": true,\n  \"episode.watched-downloaded.pairing\": true,\n  \"kc.always\": false,\n  \"lastSync\": -1,\n  \"library.order.by\": \"getSortName()\",\n  \"library.order.reverseList\": [\n    true,\n    false,\n    true,\n    true\n  ],\n  \"library.seriesgrid\": false,\n  \"library.smallposters\": true,\n  \"main.viewmode\": \"calendar\",\n  \"notifications.enabled\": false,\n  \"series.displaymode\": \"poster\",\n  \"series.not-watched-eps-btn\": true,\n  \"storage.sync\": false,\n  \"subtitles.languages\": [\n    \"eng\"\n  ],\n  \"sync.progress\": true,\n  \"synology.enabled\": true,\n  \"synology.ip\": \"192.168.x.x\",\n  \"synology.password\": \"*****\",\n  \"synology.playback_devices\": {},\n  \"synology.port\": 5000,\n  \"synology.protocol\": \"http\",\n  \"synology.username\": \"admin\",\n  \"topSites.enabled\": false,\n  \"topSites.mode\": \"onhover\",\n  \"torrentDialog.2.activeSE\": {\n    \"ThePirateBay\": true,\n    \"1337x\": true,\n    \"IsoHunt\": true,\n    \"KATcr\": true,\n    \"Nyaa\": false,\n    \"RarBG\": true,\n    \"ShowRSS\": false,\n    \"TorrentDownloads\": false,\n    \"TorrentZ2\": true,\n    \"Zooqle\": false,\n    \"ETag\": false,\n    \"ETTV\": true,\n    \"EzTV.ag\": true,\n    \"Idope\": false,\n    \"IsoHunt2\": false,\n    \"LimeTorrents\": true,\n    \"Demonoid\": true,\n    \"bj-share\": true,\n    \"BJ-Share\": true,\n    \"KickAssTorrent\": true,\n    \"IdopeClone\": true,\n    \"TGx\": true\n  },\n  \"torrentDialog.2.enabled\": true,\n  \"torrentDialog.2.sortBy\": \"-seedersInt\",\n  \"torrentDialog.showAdvanced.enabled\": true,\n  \"torrenting.autodownload\": false,\n  \"torrenting.autostop\": false,\n  \"torrenting.autostop_all\": false,\n  \"torrenting.client\": \"Transmission\",\n  \"torrenting.directory\": true,\n  \"torrenting.enabled\": true,\n  \"torrenting.global_size_max\": null,\n  \"torrenting.global_size_max_enabled\": true,\n  \"torrenting.global_size_min\": null,\n  \"torrenting.global_size_min_enabled\": true,\n  \"torrenting.ignore_keywords\": \"\",\n  \"torrenting.ignore_keywords_enabled\": true,\n  \"torrenting.label\": false,\n  \"torrenting.launch_via_chromium\": false,\n  \"torrenting.min_seeders\": 50,\n  \"torrenting.min_seeders_enabled\": false,\n  \"torrenting.progress\": false,\n  \"torrenting.require_keywords\": \"\",\n  \"torrenting.require_keywords_enabled\": true,\n  \"torrenting.require_keywords_mode_or\": true,\n  \"torrenting.searchprovider\": \"RarBG\",\n  \"torrenting.searchquality\": \"\",\n  \"torrenting.searchqualitylist\": [\n    \"480p\",\n    \"HDTV\",\n    \"720p\",\n    \"1080p\",\n    \"2160p\"\n  ],\n  \"torrenting.streaming\": true,\n  \"trakt-update.period\": 6,\n  \"trakttv.passwordHash\": \"*****\",\n  \"trakttv.sync\": true,\n  \"trakttv.username\": null,\n  \"transmission.password\": \"*****\",\n  \"transmission.path\": \"/transmission/rpc\",\n  \"transmission.port\": 9091,\n  \"transmission.progressX100\": true,\n  \"transmission.server\": \"http://localhost\",\n  \"transmission.use_auth\": false,\n  \"transmission.username\": \"admin\",\n  \"font.bebas.enabled\": false,\n  \"autodownload.lastrun\": 1530399938569\n}"
  },
  {
    "name": "Other significant Local Storage keys",
    "data": "{\n  \"1.1.4TorrentHashListCleanup\": \"Sun Dec 17 2017 23:22:52 GMT-0200 (-02)\",\n  \"1.1.4cleanupOrphanedEpisodes\": \"Sun Dec 17 2017 23:22:36 GMT-0200 (-02)\",\n  \"1.1.4cleanupOrphanedSeasons\": \"Sun Dec 17 2017 23:22:37 GMT-0200 (-02)\",\n  \"1.1.4qBittorrentPre32\": \"Sun Dec 17 2017 23:22:32 GMT-0200 (-02)\",\n  \"1.1.4refresh\": \"Sun Dec 17 2017 23:22:42 GMT-0200 (-02)\",\n  \"1.1.4refreshTrendingCache\": \"Sun Dec 17 2017 23:22:32 GMT-0200 (-02)\",\n  \"1.1.4updateTransmissionPath\": \"Sun Dec 17 2017 23:22:32 GMT-0200 (-02)\",\n  \"1.1.5FetchFirstXemAliasMap\": \"Sun Dec 17 2017 23:22:32 GMT-0200 (-02)\",\n  \"1.1.5deleteSearchEngines\": \"Sun Dec 17 2017 23:22:32 GMT-0200 (-02)\",\n  \"1.1.5fanartCleanup\": \"Sat Apr 28 2018 13:08:27 GMT-0300 (-03)\",\n  \"1.1.5updateDelugeAuth\": \"Sun Dec 17 2017 23:22:32 GMT-0200 (-02)\",\n  \"1.1.5updateTorrenting.min_seeders\": \"Sun Dec 17 2017 23:22:32 GMT-0200 (-02)\",\n  \"1.1.6deleteWatchList\": \"Thu Dec 21 2017 23:25:26 GMT-0200 (-02)\",\n  \"1.1migration\": \"Sun Dec 17 2017 23:22:35 GMT-0200 (-02)\",\n  \"CRUD.DEBUG\": \"false\",\n  \"autobackup.lastrun\": \"1558322866860\",\n  \"database.version.Episodes\": \"14\",\n  \"database.version.Fanart\": \"1\",\n  \"database.version.Jackett\": \"2\",\n  \"database.version.Seasons\": \"6\",\n  \"database.version.Series\": \"16\",\n  \"fanart.bootstrapped\": \"1\",\n  \"font.bebas.disabled\": \"true\",\n  \"github.lastupdatecheck\": \"1513560156988\",\n  \"install.notify\": \"1.1.5\",\n  \"runtime.event\": \"{\\\"reason\\\":\\\"chrome_update\\\"}\",\n  \"snr.lastFetched\": \"1558649712262\",\n  \"standalone.position\": \"{\\\"width\\\":1366,\\\"height\\\":743,\\\"x\\\":0,\\\"y\\\":25,\\\"state\\\":\\\"maximized\\\"}\",\n  \"standalone.zoomlevel\": \"6\",\n  \"torrenting.client\": \"Transmission\",\n  \"trackers.lastFetched\": \"1556723836714\",\n  \"trakttv.lastupdated\": \"1558676285835\",\n  \"trakttv.lastupdated.trending\": \"1558312956135\",\n  \"trakttv.refresh_token\": \"00f6a57021b0f02ee8775b3e439cebfb4e3c7a7a303b174c966a88f6c1b6484b\",\n  \"uniqueId\": \"fcc4c833-d67f-849d-4a18-5daec48c91cf\",\n  \"upgrade.notify\": \"1.1.6\",\n  \"xem.lastFetched\": \"1558649712286\"\n}"
  },
  {
    "name": "DB Series",
    "data": 274
  },
  {
    "name": "DB Series Hidden From Calendar",
    "data": 22
  },
  {
    "name": "DB Seasons",
    "data": 693
  },
  {
    "name": "DB Episodes",
    "data": 6556
  },
  {
    "name": "DB Fanart",
    "data": 4408
  },
  {
    "name": "DB Jackett",
    "data": 9
  }
]

Attach any DuckieTV statistics or Developer Console logs if available

[
  {
    "name": "DuckieTV Web Based",
    "data": "1.1.6"
  },
  {
    "name": "Current Date and Time",
    "data": "Fri, 24 May 2019 21:40:43 GMT"
  },
  {
    "name": "NWJS, Chromium",
    "data": "0.31.3 , 67.0.3396.87"
  },
  {
    "name": "UserAgent",
    "data": "DuckieTV-Standalone v1.1.6 X11; Linux x86_64"
  },
  {
    "name": "Platform, Vendor",
    "data": "Linux x86_64, Google Inc."
  },
  {
    "name": "Screen (width x height)",
    "data": "1366 x 768"
  },
  {
    "name": "Default Search Engine",
    "data": "RarBG [Jackett] (Enabled)"
  },
  {
    "name": "Default Torrent Client",
    "data": "Transmission (Enabled and Connected to Host)"
  },
  {
    "name": "Auto Download Service",
    "data": "(Disabled)"
  },
  {
    "name": "Last checked TraktTV for DB updates on",
    "data": "Fri, 24 May 2019 05:38:05 GMT"
  },
  {
    "name": "User Preferences on Local Storage",
    "data": "{\n  \"ThePirateBay.mirror\": \"https://thepiratebay.org\",\n  \"application.language\": \"en_us\",\n  \"application.locale\": \"en_us\",\n  \"autobackup.period\": \"weekly\",\n  \"autodownload.delay\": 15,\n  \"autodownload.multiSE\": {\n    \"ThePirateBay\": true,\n    \"1337x\": true,\n    \"IsoHunt\": true,\n    \"KATcr\": true,\n    \"Nyaa\": true,\n    \"RarBG\": true,\n    \"ShowRSS\": true,\n    \"TorrentDownloads\": true,\n    \"TorrentZ2\": true,\n    \"Zooqle\": true,\n    \"EzTV.ag\": true,\n    \"Idope\": true,\n    \"LimeTorrents\": true,\n    \"SkyTorrents\": true,\n    \"ETTV\": true,\n    \"ETag\": true,\n    \"IsoHunt2\": true,\n    \"Demonoid\": true,\n    \"bj-share\": true,\n    \"BJ-Share\": true,\n    \"KickAssTorrent\": true,\n    \"TGx\": true\n  },\n  \"autodownload.multiSE.enabled\": false,\n  \"autodownload.period\": 1,\n  \"background-rotator.opacity\": \"0.4\",\n  \"calendar.mode\": \"date\",\n  \"calendar.show-downloaded\": true,\n  \"calendar.show-episode-numbers\": true,\n  \"calendar.show-specials\": false,\n  \"calendar.startSunday\": false,\n  \"client.determinedlocale\": \"en_us\",\n  \"download.ratings\": true,\n  \"episode.watched-downloaded.pairing\": true,\n  \"kc.always\": false,\n  \"lastSync\": -1,\n  \"library.order.by\": \"getSortName()\",\n  \"library.order.reverseList\": [\n    true,\n    false,\n    true,\n    true\n  ],\n  \"library.seriesgrid\": false,\n  \"library.smallposters\": true,\n  \"main.viewmode\": \"calendar\",\n  \"notifications.enabled\": false,\n  \"series.displaymode\": \"poster\",\n  \"series.not-watched-eps-btn\": true,\n  \"storage.sync\": false,\n  \"subtitles.languages\": [\n    \"eng\"\n  ],\n  \"sync.progress\": true,\n  \"synology.enabled\": true,\n  \"synology.ip\": \"192.168.x.x\",\n  \"synology.password\": \"*****\",\n  \"synology.playback_devices\": {},\n  \"synology.port\": 5000,\n  \"synology.protocol\": \"http\",\n  \"synology.username\": \"admin\",\n  \"topSites.enabled\": false,\n  \"topSites.mode\": \"onhover\",\n  \"torrentDialog.2.activeSE\": {\n    \"ThePirateBay\": true,\n    \"1337x\": true,\n    \"IsoHunt\": true,\n    \"KATcr\": true,\n    \"Nyaa\": false,\n    \"RarBG\": true,\n    \"ShowRSS\": false,\n    \"TorrentDownloads\": false,\n    \"TorrentZ2\": true,\n    \"Zooqle\": false,\n    \"ETag\": false,\n    \"ETTV\": true,\n    \"EzTV.ag\": true,\n    \"Idope\": false,\n    \"IsoHunt2\": false,\n    \"LimeTorrents\": true,\n    \"Demonoid\": true,\n    \"bj-share\": true,\n    \"BJ-Share\": true,\n    \"KickAssTorrent\": true,\n    \"IdopeClone\": true,\n    \"TGx\": true\n  },\n  \"torrentDialog.2.enabled\": true,\n  \"torrentDialog.2.sortBy\": \"-seedersInt\",\n  \"torrentDialog.showAdvanced.enabled\": true,\n  \"torrenting.autodownload\": false,\n  \"torrenting.autostop\": false,\n  \"torrenting.autostop_all\": false,\n  \"torrenting.client\": \"Transmission\",\n  \"torrenting.directory\": true,\n  \"torrenting.enabled\": true,\n  \"torrenting.global_size_max\": null,\n  \"torrenting.global_size_max_enabled\": true,\n  \"torrenting.global_size_min\": null,\n  \"torrenting.global_size_min_enabled\": true,\n  \"torrenting.ignore_keywords\": \"\",\n  \"torrenting.ignore_keywords_enabled\": true,\n  \"torrenting.label\": false,\n  \"torrenting.launch_via_chromium\": false,\n  \"torrenting.min_seeders\": 50,\n  \"torrenting.min_seeders_enabled\": false,\n  \"torrenting.progress\": false,\n  \"torrenting.require_keywords\": \"\",\n  \"torrenting.require_keywords_enabled\": true,\n  \"torrenting.require_keywords_mode_or\": true,\n  \"torrenting.searchprovider\": \"RarBG\",\n  \"torrenting.searchquality\": \"\",\n  \"torrenting.searchqualitylist\": [\n    \"480p\",\n    \"HDTV\",\n    \"720p\",\n    \"1080p\",\n    \"2160p\"\n  ],\n  \"torrenting.streaming\": true,\n  \"trakt-update.period\": 6,\n  \"trakttv.passwordHash\": \"*****\",\n  \"trakttv.sync\": true,\n  \"trakttv.username\": null,\n  \"transmission.password\": \"*****\",\n  \"transmission.path\": \"/transmission/rpc\",\n  \"transmission.port\": 9091,\n  \"transmission.progressX100\": true,\n  \"transmission.server\": \"http://localhost\",\n  \"transmission.use_auth\": false,\n  \"transmission.username\": \"admin\",\n  \"font.bebas.enabled\": false,\n  \"autodownload.lastrun\": 1530399938569\n}"
  },
  {
    "name": "Other significant Local Storage keys",
    "data": "{\n  \"1.1.4TorrentHashListCleanup\": \"Sun Dec 17 2017 23:22:52 GMT-0200 (-02)\",\n  \"1.1.4cleanupOrphanedEpisodes\": \"Sun Dec 17 2017 23:22:36 GMT-0200 (-02)\",\n  \"1.1.4cleanupOrphanedSeasons\": \"Sun Dec 17 2017 23:22:37 GMT-0200 (-02)\",\n  \"1.1.4qBittorrentPre32\": \"Sun Dec 17 2017 23:22:32 GMT-0200 (-02)\",\n  \"1.1.4refresh\": \"Sun Dec 17 2017 23:22:42 GMT-0200 (-02)\",\n  \"1.1.4refreshTrendingCache\": \"Sun Dec 17 2017 23:22:32 GMT-0200 (-02)\",\n  \"1.1.4updateTransmissionPath\": \"Sun Dec 17 2017 23:22:32 GMT-0200 (-02)\",\n  \"1.1.5FetchFirstXemAliasMap\": \"Sun Dec 17 2017 23:22:32 GMT-0200 (-02)\",\n  \"1.1.5deleteSearchEngines\": \"Sun Dec 17 2017 23:22:32 GMT-0200 (-02)\",\n  \"1.1.5fanartCleanup\": \"Sat Apr 28 2018 13:08:27 GMT-0300 (-03)\",\n  \"1.1.5updateDelugeAuth\": \"Sun Dec 17 2017 23:22:32 GMT-0200 (-02)\",\n  \"1.1.5updateTorrenting.min_seeders\": \"Sun Dec 17 2017 23:22:32 GMT-0200 (-02)\",\n  \"1.1.6deleteWatchList\": \"Thu Dec 21 2017 23:25:26 GMT-0200 (-02)\",\n  \"1.1migration\": \"Sun Dec 17 2017 23:22:35 GMT-0200 (-02)\",\n  \"CRUD.DEBUG\": \"false\",\n  \"autobackup.lastrun\": \"1558322866860\",\n  \"database.version.Episodes\": \"14\",\n  \"database.version.Fanart\": \"1\",\n  \"database.version.Jackett\": \"2\",\n  \"database.version.Seasons\": \"6\",\n  \"database.version.Series\": \"16\",\n  \"fanart.bootstrapped\": \"1\",\n  \"font.bebas.disabled\": \"true\",\n  \"github.lastupdatecheck\": \"1513560156988\",\n  \"install.notify\": \"1.1.5\",\n  \"runtime.event\": \"{\\\"reason\\\":\\\"chrome_update\\\"}\",\n  \"snr.lastFetched\": \"1558649712262\",\n  \"standalone.position\": \"{\\\"width\\\":1366,\\\"height\\\":743,\\\"x\\\":0,\\\"y\\\":25,\\\"state\\\":\\\"maximized\\\"}\",\n  \"standalone.zoomlevel\": \"6\",\n  \"torrenting.client\": \"Transmission\",\n  \"trackers.lastFetched\": \"1556723836714\",\n  \"trakttv.lastupdated\": \"1558676285835\",\n  \"trakttv.lastupdated.trending\": \"1558312956135\",\n  \"trakttv.refresh_token\": \"00f6a57021b0f02ee8775b3e439cebfb4e3c7a7a303b174c966a88f6c1b6484b\",\n  \"uniqueId\": \"fcc4c833-d67f-849d-4a18-5daec48c91cf\",\n  \"upgrade.notify\": \"1.1.6\",\n  \"xem.lastFetched\": \"1558649712286\"\n}"
  },
  {
    "name": "DB Series",
    "data": 274
  },
  {
    "name": "DB Series Hidden From Calendar",
    "data": 22
  },
  {
    "name": "DB Seasons",
    "data": 693
  },
  {
    "name": "DB Episodes",
    "data": 6556
  },
  {
    "name": "DB Fanart",
    "data": 4408
  },
  {
    "name": "DB Jackett",
    "data": 9
  }
]
garfield69 commented 5 years ago

I have noticed that other punctuation marks are correctly replaced with a space.

I don't believe this is the case. all special characters are stripped apart from minus and spaces. https://github.com/SchizoDuckie/DuckieTV/blob/260d8494ddd41ed64569b17648f4e6208c9a7b84/js/services/SceneNameResolver.js#L27-L32

I believe that any series where it appears we are replacing special characters with spaces are actually full title replacements using the exceptions table.

I'm happy to just add those series names you reported to the exceptions table, that is what it's there for.

far easier to do that, than to experiment with replacing some special chars with spaces, as I don't know what the downstream effect of this will be to other series that do not have exceptions table aliases.

I've added what/if and fosse/verdon to the exceptions table, feel free to report any others. Your Dtv should pick up the latest exceptions table update in the next 24 hours.

marcelpaulo commented 5 years ago

I don't believe this is the case. all special characters are stripped apart from minus and spaces.

I can't remember the series where I noticed the diacritic being replaced with space. If I bump into it again, I'll update it here, just in case.

I've added what/if and fosse/verdon to the exceptions table, feel free to report any others.

Thanks a lot, @garfield69!

garfield69 commented 5 years ago

FYI diacritics are characters with inflections https://github.com/SchizoDuckie/DuckieTV/blob/260d8494ddd41ed64569b17648f4e6208c9a7b84/js/services/SceneNameResolver.js#L19-L25