Add additional options to searchqualitylist

[ilike2burnthing]

Not tested, but based on https://github.com/SchizoDuckie/DuckieTV/commit/163a3a8452c6e8ecca6b8baa9feac9b7ae0804b5.

[garfield69]

the current dialogue looks like this: the change will make the dialogue look like this:

notice how we have lost some real estate because the list is longer than fits after the search-box. At this point we have a choice to make, we either drop one of the original qualities so we can fit WEB in, or accept the new list in its new position, or make use of the full line by adding other quality options, such as 720p x264, 720p x265, 1080p x264, 1080p x265, x264, etc. Thoughts?

[ilike2burnthing]

Ah, I have always had DuckieTV snapped to one side of the screen, so the quality options have always been on a new line for me. It was never really an issue for me.

x264 seems like a good one to add. I personally wouldn't use them, but xxx0p x264 and xxx0p x265 sound fine if they were in addition to 720p and 1080p, rather than replacing them.

Alternatively, though this would require work outside of my abilities, you could allow selecting multiple options, e.g. WEB + 1080p + x264. Would be less cluttered and allow for more combinations.

[garfield69]

Alternatively, you could allow selecting multiple options, e.g. WEB + 1080p + x264. Would be less cluttered and allow for more combinations.

Yeah, nah, that is far too much work. I once tried implementing checkboxes for the qualities and it is a lot of work to implement, not so much the GUI but behind the scenes where ADS and Dialogue require changing plus series Settings for individual options.

but xxx0p x264 and xxx0p x265 sound fine if they were in addition to 720p and 1080p, rather than replacing them.

I initially tried HDTV,WEB,720p,1080p,2160p,x264,x265,720p x264, 720p x265, 1080p x264, 1080p x265, 2160p x264, 2160p x265 but its too long, and only doing it for 720p and 1080p and not 2160p seemed incomplete.

So I've put togeather a list of what I think are the most common quality types: AV1,HDTV,HDR,HMAX,WEB,480p,720p,1080p,2160p,H264,H265,x264,x265,XviD which looks something like this on my private Dtv

Opinion?

[ilike2burnthing]

Looks good. Only one I'd take out is HMAX, as I think that's the abbreviation for HBO MAX rather than a quality (and then you'd have to add in IPTV, ATVP, DSNY, SVT and all the others).

Suggested order (a vague 'worst to best' order for source, resolution, and codec):

HDTV,WEB,480p,720p,1080p,2160p,HDR,XviD,x264,x265,H264,H265,AV1

[Js41637]

I don't personally like the affect these changes have on the UI. It adds a lot of bloat. I don't think a web option is needed but perhaps you can just make the search box a bit smaller, reduce some padding, etc to make it fit.

[garfield69]

okely dokely. update the pr and I will merge ;-)

[garfield69]

well with regards to WEB, or any other parm for that matter, there is always the option as a user to simply add it to the required keywords list in settings. which would make this PR redundant ;-b

[ilike2burnthing]

The benefit over a required keyword is that you can quickly jump through different options. Sometimes the WEB version takes a few more hours to come out, or only a 1080p version is available, so even if your preference is 720p WEB (waves) if you don't want to wait, you can jump through a few of the options to see what's actually available (without being flooded by the All option).

[garfield69]

For myself I use the ADS for my downloads, and I only start Dtv when I want something. Usually its to batch download episodes for the previous week on Mondays, as I usually just binge watch a series once I have the whole season, rather than waiting to watch something just an hour after broadcast. But this PR would certainly cater for those that use the search dialogue and manually look for episodes to get their fix asap. ;-D

[ilike2burnthing]

I need my fix damnit! 😋

[garfield69]

@Js41637 so what do you think, we go ahead with this and see if we get any negative feedback, or trim it back to the original list + WEB and shrink the search name box a bit to fit? I'm not fussed either way.

[garfield69]

How about this then?

[garfield69]

replaced by 7077337684ae96a836d071b52fa0944f988d377b [edit] plus 5c3324517a73812ac2a2641598861d035814b3e9

[garfield69]

https://github.com/DuckieTV/Nightlies/releases/tag/nightly-202401272120

[ilike2burnthing]

Looks good! Ta :)