search

Schlumberger / vsts-chromium-task

MIT License
0 stars 1 forks source link

Would you consider a PR to switch to tool installers #4

Open sandorfr opened 6 years ago

sandorfr commented 6 years ago

Hi,

Would you consider accepting a PR switching from powershell to node engine. That would allow the extension to leverage tool installer APIs.

https://github.com/Microsoft/vsts-tasks/blob/master/docs/tools.md

Kind regards, Cyprien

sandorfr commented 6 years ago

Also please consider merging #3 and removing the [Preview] flag from the title. (the marketplace already shows a preview label because of the flags).

helgejfo commented 6 years ago

I would accept a PR changing to node. The preview flag was added to validate the current script for a while before removing it. I would like to keep the preview for the new solution as well, for a while at least to validate the changes.

sandorfr commented 6 years ago

Yes my comment was not about the preview flag but the [preview] in the extension title. I think it's a bit redundant.