SchmarrnDevs / Lighty

The Light Overlay Mod with a twist!
https://modrinth.com/mod/lighty
Apache License 2.0
18 stars 13 forks source link

Added integration with Mod Menu #56

Closed poqbox closed 6 months ago

poqbox commented 7 months ago

I've only done a bit of modding with Fabric, but I wanted to be able to configure this mod through Mod Menu. I also saw that this was planned in #30. I haven't modded with NeoForge, so I'm not sure if it will work with that.

There are a couple issues I noticed, so I'll list them here.

This should work without any config mods like Cloth config or YACL.

poqbox commented 7 months ago

I didn't changed the mod version number either. Wasn't sure of which number to change.

andi-makes commented 7 months ago

Thank you very much for this PR! I appreciate your contribution!

I am currently quite busy with university assignments and adding finishing touches for Lighty for Minecraft 1.20.5, but I hope to be able to review this PR and #58 this weekend. Thank you for your understanding!

poqbox commented 7 months ago

I've made some changes.

No need to rush the review if you're still busy, I just did it cause I felt like it.

poqbox commented 7 months ago

No problem, just glad to get ModMenu integration with Lighty.

poqbox commented 6 months ago

np