search

SchmarrnDevs / Lighty

The Light Overlay Mod with a twist!
https://modrinth.com/mod/lighty
Apache License 2.0
10 stars 8 forks source link

Implemented dimension-specific light thresholds #58

Closed poqli closed 2 months ago

poqli commented 2 months ago

Suggested this in #57, and wanted to try to implement it. The API now accepts dimension data. Lighty modes now send dimension data to the API. Since some values were being used multiple times, I decided to create a central variable for the methods that did so. With the addition of dimension-specific thresholds, I decided to append "overworld_" to the start of the original threshold names.

andi-makes commented 2 months ago

Thanks again for taking your time to work on Lighty. It is highly appreciated!

I am currently in the middle of rewriting huge parts of how Lighty works internally to neatly integrate a few new features. As a result, most of the existing logic regarding Lighty Modes needs to be rewritten.

One of those features is dimension-specific light thresholds. They aren't really possible to implement cleanly with the current state of Lighty. So sadly, I won't accept this PR.

I'm still very thankful for your work! I hope you understand.

poqli commented 2 months ago

Fair enough.

poqli commented 5 days ago

I saw that large chunks of the code has been rewritten. Did you finish the rewrite? I'm looking to implement dimension-specific thresholds again.

andi-makes commented 4 days ago

I'm not yet finished with the rewrite, but I will probably finish it over the course of the next two months (hopefully)

poqli commented 4 days ago

Do you want some help with it? Not sure if I can code what you want, but I'd be using the rewritten code as reference. For example, the code structures for the different modes are different from each other. I could use the rewritten one as reference for rewriting the other ones.

andi-makes commented 2 days ago

Sorry for the wait!

I'd prefer to write it myself, because that's one of the things that are still fun to me—thinking about how to optimize and how to improve the codebase.

Thank you very much for your offer! But I have to decline it.