search

SchmarrnDevs / Lighty

The Light Overlay Mod with a twist!
https://modrinth.com/mod/lighty
Apache License 2.0
18 stars 13 forks source link

Implemented a "show/hide skylight level" feature #69

Closed poqbox closed 4 months ago

poqbox commented 5 months ago

Mentioned in https://github.com/SchmarrnDevs/Lighty/issues/66 Show/hide seemed easier to implement than resize. Also configurable in the settings screen.

poqbox commented 5 months ago

As a side note/suggestion, could you flip the positions of skylight and blocklight levels?

I didn't implement it in this commit, but I think it would be thematic to put the skylight level on top so that it matches how the sky is situated over the blocks beneath it.

andi-makes commented 5 months ago

I'll review later today, but I wanted to provide an answer to this:

I didn't implement it in this commit, but I think it would be thematic to put the skylight level on top so that it matches how the sky is situated over the blocks beneath it.

I don't really want to change that behavior, it has been like that since the introduction of the number mode, and the existing translations to languages other than English would be out-of-date in a "dangerous" way, because they'd be just plainly wrong.