Schmavery / facebook-chat-api

Unofficial Facebook Chat API for Nodejs
MIT License
1.94k stars 597 forks source link

Do api.changeThreadColor and api.changeNickname still work? #378

Closed AlexCloudDev closed 7 years ago

AlexCloudDev commented 7 years ago

Hi, i'm working on porting all functionalities of the facebook-chat-api to a Python fbchat api and everything works well, except these two functions(and likely api.changeThreadEmoji too). I haven't tested the original functions in java so far and to narrow down the problem i want to ask: Can anybody confirm they are working? Thx

AstroCB commented 7 years ago

What kind of errors are you getting?

AlexCloudDev commented 7 years ago

Hi I'm getting no error codes. The request my script creates and sends to the fb servers seems correct. The servers answer with an ok, like to the other requests (e.g. add user to chat..., which work), but the nickname/threadColor doesn't change. I guess it has something to do with the way this three specific functions, which affect manipulating group chats and were added afterwards, are treat differently by using the messenger URL in contrast to the other requests using the fb URL.

Either this three functions are handled differently and my implementation doesn't take this in consideration or the java functions are also broken because of an fb update or never worked at all. Idk Thx for contributing

Schmavery commented 7 years ago

@AstroCB are these functions working for you? @AlexCloudDev sorry, I keep forgetting to test this on my machine that has the tests set up (on mobile now). I'd suggest you install the api and test manually on your own facebook account. This will be the most accurate test of functionality (as it sometimes depends on the account used).

AstroCB commented 7 years ago

@Schmavery Yes, they're working fine for me.

Schmavery commented 7 years ago

@AstroCB thanks! I'll close this since it technically answers @AlexCloudDev's question. Feel free to follow up with any more relevant comments/questions!

AlexCloudDev commented 7 years ago

Ok, thx for confirmation. I have to take a closer look into my code.

Schmavery commented 7 years ago

@AlexCloudDev I'd still suggest trying the api with your facebook account if you continue to have problems. Sometimes Facebook rolls out a change slowly so it will work for one account and not another.