Schmavery / reprocessing

ReasonML graphics library inspired by Processing
https://schmavery.github.io/reprocessing/
MIT License
682 stars 24 forks source link

Fix crash when opening native / bytecode without hotreloading. #108

Closed bsansouci closed 6 years ago

bsansouci commented 6 years ago

when not in hotreloading mode

bsansouci commented 6 years ago

Otherwise we get a unix error when trying to hotreload a file whose name is empty string here

Schmavery commented 6 years ago

Is it clear that we should be doing this instead of handling the empty string on the hotreloading end (and not attempting to recompile or something). I don't fully grasp the Hashtbl code right now.

cc @jaredly

bsansouci commented 6 years ago

Ok fixed it checking the file name. That code path was always executing anyway (the one I removed) and empty string is probably a good default anyway.

Schmavery commented 6 years ago

lgtm