Is there a way to set the window title?

Schmavery / reprocessing

ReasonML graphics library inspired by Processing

https://schmavery.github.io/reprocessing/

MIT License

679 stars 24 forks source link

Is there a way to set the window title? #127

Closed jozanza closed 5 years ago

jozanza commented 5 years ago

I've been exploring the docs and the source code for this lib as well as the reasongl library, and I'm at a loss for how to set the window title. Is this supported?

Schmavery commented 5 years ago

Embarrassingly enough, I think there might not be a way. I'll see if I can do something about that, sorry...

https://github.com/bsansouci/reasongl/blob/118e254bec0de1210a62176cf8520ab842cf6377/src/native/reasongl_native.re#L27

jozanza commented 5 years ago

No problem! I ran into that same code block and thought, "There must be some other way to do this. I must have missed something". haha

Keep me posted 👍

Schmavery commented 5 years ago

I think I originally didn't do this because I wasn't sure what should happen on web. Do you think it's fine if it just updates document.title?

jozanza commented 5 years ago

Yeah that seems fine.

Schmavery commented 5 years ago

This functionality is on its way :) https://github.com/bsansouci/reasongl/pull/13

Schmavery commented 5 years ago

Thanks for the suggestion, it should be usable now so let me know if it has any issues :)

jozanza commented 5 years ago

@Schmavery are you going to publish a new version to npm?

Schmavery commented 5 years ago

fair enough, just published 0.1.1

jozanza commented 5 years ago