Fix for cable modems - Githubissues

Schmidsfeld / TelegrafFritzBox

Telegraf collector help file for the FritzBox by AVM

MIT License

51 stars 12 forks source link

Fix for cable modems #5

Closed chevdor closed 4 years ago

chevdor commented 4 years ago

This PR properly gets the connectionInfo for cable modems

chevdor commented 4 years ago

Before that I remove the superstrongpassword default that we def. don't want. I also fixed the NAME of the ENV which is likely causing your troubles.

I suggest we get a working version together and you fix the style as you wish. For now, I started packing thing into functions will make it later more testable.

I am rather new to the TR-064 specs but it sounds like we may be able to avoid the issue entirely using the something like WANCommonInterfaceConfig1. That should give us metrics common to DSL and cable.

Schmidsfeld commented 4 years ago

Ah yes The password and the missing default (before that the missing comma before the default was my connection problem. - I have a script to replace "SuperStrongPassword" with my actual password when pushing it onto the Pi when deploying ...

I think you found and solved the problem for the root cause 👍 I will get a working version based on WANCommonInterfaceConfig1 going. Also the detection of the connection type and appropiate 'Special' stats should be no problem.

Hope to be able to provide a new version later today / tommorrow.

With your help testing it and detecting some output we soon should have a universal version.

Thank you for contributing so much to this project!

Schmidsfeld commented 4 years ago

Sorry bit this build makes the code horrible broken for DSL Line! Cant merge at the moment!

chevdor commented 4 years ago

No problem, I am blind on the DSL side... What is the issue ?

There are only a few places to check:

is the isDSL function working fine ?
is the code inside the DSL only block working fine ?

chevdor commented 4 years ago

I checked the PR again and if there is an issue, it must be in isDSL. The rest did not change in functionality.

Schmidsfeld commented 4 years ago

Sorry this is horrible broken for DSL Lines. All the specialized stats (FEC Errors are missing! I cant merge it in this form.

I will get a workarround for cable done myself. Seems less work than chasing down the errors and adjusting the code to be constistent with the prevalent style...