Use newer Faker.js? - Githubissues

Schniz / bs-faker

Faker.js bindings for BuckleScript in Reason

MIT License

17 stars 8 forks source link

Use newer Faker.js? #34

Open Schniz opened 5 years ago

Schniz commented 5 years ago

Do you think we should use the git repo instead of npm for our faker dependency? Looks like it wasn't updated in npm, while the master branch keeps updating and getting more features.

I dislike using git repos as npm packages, because you can't "proxy" it using your own, internal npm. but maybe it's better this way.

What do you think? we can also fork it or whatever...

cc @miluoshi @deanshub @spencerwi @ohana54

miluoshi commented 5 years ago

Looks like they are approaching v5.0.0 release soon https://github.com/Marak/faker.js/issues/692, so maybe it would be worth just waiting for the new version.

Marak commented 5 years ago

I would recommend to start testing against faker master branch on Github if possible.

We are getting close to a new major and would appreciate the testing.

We've also added a few new API methods, locales, and bug fixes.