Schniz / bs-faker

Faker.js bindings for BuckleScript in Reason
MIT License
17 stars 8 forks source link

Add bindings for `date` #38

Closed yamadayuki closed 5 years ago

yamadayuki commented 5 years ago

This PR closes https://github.com/Schniz/bs-faker/issues/5

Now the latest Faker.js has no API called soon (I suppose), so I implemented APIs below:

date
    past
    future  <- Added
    between <- Added
    recent  <- Added
    soon
    month   <- Added
    weekday <- Added

Now the latest Faker.js has no API called soon (I suppose)

~/dev/src/github.com/yamadayuki/bs-faker date-bindings
❯ node
> const date = require('faker').date
undefined
> date
_Date {
  past: [Function: bound ],
  future: [Function: bound ],
  between: [Function: bound ],
  recent: [Function: bound ],
  month: [Function: bound ],
  weekday: [Function: bound ] }
> date.soon
undefined
Schniz commented 5 years ago

hey there! thanks for the contribution! looks very very good. what do you think about what I suggested? 😄

Schniz commented 5 years ago

Amazing. Thanks!

Schniz commented 5 years ago

Published on v1.2.0