search

SchokkerIT / GameDash

Official repository for the GameDash project
21 stars 0 forks source link

UFW does not get installed by the installation script so adding UFW commands is pointless if clean system. #12

Open minecraftdan1234 opened 4 years ago

minecraftdan1234 commented 4 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Install GD using installation script.
  2. Notice during install UFW commits 3 commands but states Not found since it is not installed on a clean system and does not come included in the script.

Expected behavior Either install UFW or remove those commands entirely.

Screenshots image

Desktop (please complete the following information):

aleforge commented 4 years ago

Ubuntu ships with UFW by default even in a clean image. Your VPS provider may be disabling it in their custom images. This can be ignored as it was just added due to a firewall bug that was discovered that prevented communication between the docker containers if the rules were not set up.

I personally ran this on an Ubuntu 20.04 and 18.04 from DO and UFW was installed by default.

Removing these commands would cause issues resolved bugs to return and there should be no reason to install UFW since the OS ships with it. There is also no way of knowing what else a customer runs on that machine so installing a firewall when there was not one is outside the scope of a GameDash install script in my opinion.

A better way to fix this would be to check to see if UFW is installed prior to running those commands but since it is a default software in the OS it really shouldn't be necessary.

minecraftdan1234 commented 4 years ago

Interesting. Alright, I will wait for Jesse to close this. It is interesting that a dedicated server from Hetzner did not have UFW already installed. No worries.

Jesse-Schokker commented 4 years ago

Will add a check to the install script to make sure that UFW is installed before executing those commands.

AlthalusAvan commented 4 years ago

Hetzner doesn't include UFW in their images, as they push their customers towards using their router-level firewalls via the Hetzner control panel.

A quick "is UFW installed" check doesn't hurt, but I'd echo the sentiment that it shouldn't be forcibly installed if it's not already present.