Open ivanromakh opened 2 years ago
https://scholar6.zendesk.com/agent/tickets/690
Pysics and maths bricks shouldn't be in subject category 3
Looks like there's a more general issue with the subject-category dashboard: https://app.brillder.com/play/dashboard/subject-categories
Have tested both logged in and not logged in, and I get the same bricks no matter which subject group I click, though note subjects column on left does change:
server side pagination isn`t working with subject categories.
This is still really bugged for me, as is the subject column on the left of the screen:
From this link: https://dev-app.brillder.com/play/dashboard/subject-categories
In all cases, if you click an icon the next page says 'All bricks', shows a selection of bricks from incorrect subjects, and gives you a total of these. The subjects in the column on the left match the subject-category though. Also, if you then click the down arrow it loads all bricks and gives a total of 220+
General & Topical links to subject group 4 and appears to give me Eng Lit bricks Humanties & Soc Sci links sg3, then shows languages bricks Languages is sg2 and shows four history bricks Maths & Comp, sg6, shows science bricks and says 32 found (we have 90+ maths bricks) Science, sg5, loads gen and topical
From that page, also arts icon should be active and link to history of art.
Let me know if you want to think this through together - looks like the first issue is with links to the wrong subject groups.
@s-steddy I have clicked humanities and it seems to work fine.
I didn`t find all bricks text
when I clicked languages category there are only 4 bricks.
oh I see it is getting wrong subjects
Looks much better, but two more issues:
@s-steddy I fixed Arts icon. about second point. it works for me. when I click from my subjects to all subjects they are changing. maybe you have too much subjects. if you have all subjects in profile page then there will be no difference.
The subject categories are now working as they should, but the selection column still isn't, and it doesn't seem to be a problem with my subjects. Testing in dev, with chrome, here's what happens when I try the languages subject category:
On clicking through, everything looks good: correct subjects loaded: French, English Lang, Spanish, ..... There are 9 bricks in these subjets and the number at the top is correct. Column on left says "All subjects":
If I then click the down arrow expecting to see the next set of bricks in the subject area, I don't get the next three bricks in Languages. Instead it loads all bricks, I think by publication date, and changes the total to 221. The "all subjects column' doesn't change either.
If after getting to the Languages subject area I select "My subjects" the column narrows the display to just my subjects within Languages: English Lang and French. But what's shown is all bricks from all subject areas, so you get a total of 172.
If you click down from here, it continues to shows all "my subject" bricks.
We need to actually clarify what we mean by all subjects and my subjects, and I need to check about what happens when a user is not logged in too. I'll try and set this out with some new checkboxes in another comment
I think we need some wider feedback on the difference between 'subject areas' 'my subjects' and 'all subjects' because we're essentially trying to run three filters with a column that only has space for two. Let's raise a separate issue for this.
But, the issues with navigating with the arrows needs fixing. So, if you have selected a subject group from the dashboard:
This is clearly working much better these days, but I noticed a couple of details to fix:
[x] Add brick counts in the sidebar when not logged in - you can see them when logged in:
[x] When logged in, clicking to 'my subjects' didn't seem to do anything (ie. in sidebar like in above pic). When clicking on this, load user's subjects. If they click back, load what was there before (ie. all bricks within a subject area)
[ ] Add a back button to go back to the subject dashboard after you've clicked on an option (might need a quick design for this from Ghada).
@s-steddy I have a few suggestions here:
I can't think of a purpose for the white section holding the category title and up-down arrows in the side menu so my suggestion is we remove it.
When I click on a subject to filter, the subject gets moved to the top of the list which is a confusing behavior, my suggestion is: when a subject is clicked, change its background to white without changing its order in the list and show the "X" button to unselect it
When a subject is selected in filter, show an "X" button in place of the number of bricks so users can click on it to remove the filter. If all subject filters are unselected, the page goes back to the default state which is showing all bricks in the category.
Add breadcrumbs at the top of the page so that I can go back to the categories dashboard by clicking on the yellow "Catalogue" label at the top.. please note that the "Catalogue" label should be underlined when hovered to indicate that it is clickable. This pattern can be used in other places to navigate through pages.
https://www.figma.com/file/LMraQn88VxZ9cHt1CAiZXN/Brillder?node-id=3662%3A627&t=tW4jw5CnRh7NRXN7-4
@GhadaShebl arrows were for scrolling subjects probably. I removed for incognito user as subjects groups have less subjects. no scrolling is needed.
That wasn't my point - I chose Humanities but had science bricks arrive in my selection.