Open ivanromakh opened 2 years ago
It's working, I can see that builder window has the adaption message and that assignees can see the word 'adapted' and the copy icon in front of the title.
But can I suggest some fixes? You might want to send this to Ghada for design.
Here's what you see after starting to adapt the brick. This is the public building window, so we don't want options to send to publisher, etc. and we don't want the risk of somebody creating duplicate bricks in the public catalogue.
For players (I got to this screen with the url from the share button):
@s-steddy if you are author the brick you adapted will be Public. What do you mean by lock brick to personal. You mean user will not be able to switch that brick to Public?
I have removed exception for author in dev. Joe also told me about this before so it is hard to understand, simple rules are better probably.
@s-steddy adapted by going to look like this.
@s-steddy I tried to test it in phone but it seems like title is too long. should I make title scrollable or elipsis? two lines?
made it in two lines if overflowing.
made it in two lines if overflowing.
Two lines looks good - can the text be centred?
@s-steddy adapted by going to look like this.
Also looking good, but shouldn't it read something like "[quill icon] [Author], [copy icon] adapted by [Educator]"? Needs the comma at least
@s-steddy problem is it is hoverable. I can add coma.
@s-steddy
@s-steddy when I published brick I got only one email. is there something wrong with it?
The problem is that it's the same email as if you publish a brick, ie. a public one. Not in and of itself a problem, but technically, an adapted brick isn't published, it's just created.
We could create a new email for adapted bricks but this would require design work and I don't think it's really necessary - you'll know that you have finished adapting a brick because you don't have to wait for an editor.
@s-steddy I see. they can't receive that email anymore. adapted bricks are personal now. when you publish personal brick you don`t get emails.
@s-steddy I am not sure about intro js. When I should show it? I should show it every time user adapted brick?
Hmm, good question. How about just the first time a user gets to the builder panel after clicking adapt a brick? If and when they return, don't show it.
But if they adapt another brick, show it the first time they adapt that brick, etc.
ok
Can see the changes have been made, but noticed a few more issues:
i. Text at top of builder panel with title got stuck, I saw this when it should have said "Adaption by Sam+etc". It was correct later though.
ii. Hover-over on icon still says 'Publish':
iii. On clicking this button, you still get a message about publishing.
iv. I still got emails (was in dev, so maybe are off in production?), and also notifications.
Tbh I can't work out why all these come through, but
v. Back at cover, you're able to adapt an adaption...
vi. After clicking 'publish (ie. upload') the brick's status is no longer draft. If you then go back to the brick from the personal list, there is a button which makes it possible to make the brick public again. (I clicked this and a copy draft appeared in my list of public bricks).
-[ ] Remove this button for bricks with this status (non-draft? with editor?).
@s-steddy popup
I will add those two buttons inside
Work from this has been moved to #4693. Moving to deploy.
zendesk ticket: https://scholar6.zendesk.com/agent/tickets/728
Quote from Joe:
I also notice that there is nothing to indicate - to players - that it is an adapted brick. The title should say "adaptation by [teacher/author]"