Scholar-6 / brillder

Apache License 2.0
3 stars 11 forks source link

Iframes should be updated for Heart of Mercia #4687

Open ivanromakh opened 2 years ago

ivanromakh commented 2 years ago

similar to IframesBricks

We need to make every link say origin=canvas or whatever that origin was we made already Every link should have target=parent or whatever opens the link in the parent window of the iframe The brillder icon should link to catalogue, with origin=canvas so it does microsoft sso if it needs to And in the case of the brillder icon that goes to the catalogue it is target=_blank not parent And when you have done that you need to do a separate iframe url for each subject. Or at least maths, english, physics and general That is everything for iframe Then for users with origin=canvas arriving at the brick cover we need to catch the origin header and return users to the same origin when the click the final button on the Brick (the one that would normally take you to the catalogue or the play attempts library)

5 iframes for each subject

ivanromakh commented 2 years ago

target=parent set

ivanromakh commented 2 years ago

iframes are done. all of them are in this page. https://brillder.com/bricksIframeCanvas/index2.html

ivanromakh commented 2 years ago

its not working it is redirecting to https://brillder.com instead of the url of page where iframe is.

ivanromakh commented 2 years ago

I will need to put returnUrl as query string probably from iframe. maybe because I use local file.

s-steddy commented 2 years ago

I was redirected to brillder.com, not back to canva

ivanromakh commented 1 year ago

@s-steddy do you have access to canvas site. could you share link so I can check it as well.

ivanromakh commented 1 year ago

I will try to use this one: window.parent.location.href.

s-steddy commented 1 year ago

This looks to be working as intended now.