search

Scholar-6 / brillder

Apache License 2.0
3 stars 11 forks source link

Unwanted "Adapted by" message #4693

Open s-steddy opened 2 years ago

s-steddy commented 2 years ago

This stems from work related to Adaption function (see #4671)

Adapted bricks now carry indicators of adapted status. However, this has caused an unwanted "Adapted by" message to appear on covers of Bricks in Public Catalogue, including eg. the current maths competition brick:

Screenshot 2022-08-31 at 16 36 19

I believe this stems from two sources. THERE COULD BE MORE SO NEEDS TALKING THROUGH: A: In building process, switch from, I believe personal to public creates a new brick which is the 'adaption'. (Mostly Toby, but also me) B: Sasha adapts bricks for competitions to make them fit a subject area.

We need to make the bricks which are the published versions the 'original', ie. not an adaption, and I think we can safely remove the adapted competition versions. Currently the original is either in the personal list (A) or a duplicate that hasn't been removed (B). This requires database access (if possible).

Bricks affected (this is just from me eyeballing through all bricks in the build catalogue looking for bricks with the copy symbol instead of a level): 489 838 925 936 938 966 1007 1183 1193 1194 1195 1196 1231 1232 1234 1273 1285 1292 1308 1416

ivanromakh commented 1 year ago

489 is not a copy. image

ivanromakh commented 1 year ago

removed adapted from: 838 925 966 1007 1193 1194 1195 1196 1231 1232 1234 1273 1285 1292 1308 1416

Most of them were Toby bricks.

ivanromakh commented 1 year ago

there is no brick with id: 936

ivanromakh commented 1 year ago

@s-steddy I need confirmation for bricks 938 and 1183. Original author there is different from the one who adapted them so need confirmation before removing adapted from. Not sure who should be the author.

s-steddy commented 1 year ago

I've checked all the bricks and can see no errant adaption messages now.

There was one duplicated brick with author, editor, and adapted by, (de Gaulle) and I'm not sure how this happened, but that copy has been unpulished leaving the original restored with dual subject.

I think we can close for now.

s-steddy commented 1 year ago

Sorry, there's still a few things: the redirects in the popup and email aren't right:

i. Both buttons redirect to cover page

Screenshot 2022-09-27 at 15 52 19

ii. Link in email doesn't take you to brick but dashboard: https://dev-app.brillder.com/play/dashboard?subjectId=15

iii. Once an adapted brick has been 'uploaded/self-published' a button appears to make public. Is this just because I have publisher access?

Screenshot 2022-09-27 at 15 54 50
ivanromakh commented 1 year ago

link in email will lead to play cover

ivanromakh commented 1 year ago

Question: iii. Once an adapted brick has been 'uploaded/self-published' a button appears to make public. Is this just because I have publisher access?

As I see it creates copy of brick in Draft status in public tab. Author can do it as well.

ivanromakh commented 1 year ago

fixed 1st point . personal button will go to personal tab in build.

ivanromakh commented 1 year ago
  1. from email user will go to cover page now.
s-steddy commented 1 year ago

Ok I think this is working well enough for now. I'm sure we'll return one day but the emails and buttons are working as intended.