Open ivanromakh opened 2 years ago
The sort buttons on columns don't work as indicated.
For one, they only sort one way, so either enable sorting in the other direction (useful for dates), or the icon should be a single down arrow, not an up-and-down arrow.
The sort-by-date-published option doesn't seem to be working right, not sure what's caused this:
Sorting by visibility (or better, filtering) is probably a good idea.
I'm not sure if this is a current connection issue, but the search bar doesn't seem to be working. Here I'm searching for Peres - you can see Toby's brick in the list. Same if I try with a title
The export function is working pretty well, but add a timestamp to the filename to avoid the risk of downloads being overwritten
Lastly for the Bricks panel, clicking on a timeframe more than a week takes a while to return results, but there's no response on click. Make sure the radio button fills on click, then maybe add a spinner somewhere? I'll keep thinking
This is getting too long a list so going to run through the Classes Panel in a separate issue
See #4748 for classes panel and #4749 for users panel
Just a thought - do we want the brick title to be clickable, and to direct to the brick? And would it be easy to navigate back from there?
From Joe: Add a sponsor field
@s-steddy sponsor field added. As I remember only text
sort by date should work now. using date created when date published is empty.
Update on 23rd Nov:
The subject selection sidebar is better, but still not working perfectly. It should be more like the category selection sidebar in the catalogue, really. So:
Instead of plain alphabetical list:
[x] The list should have at the top, like this, just the subjects for which we have bricks but in alphabetical order (but no need for numbers):
[x] When a subject is 'checked' (ie. selected), base the design on the catalogue page again, ie. an outlined circle in the subject colour, like this. So, not this:
But for this, unlike in catalogue (which will need work some time) have the line highlight to light blue, not white, and don't move to top of list:
The dropdown category selection seems to be loading the right bricks in the window, but in the sidebar the right thing doesn't happen. The only dropdown option that seems to select the right subjects is Art and Design. Here, I've selected science, so it has loaded science bricks in the window, but the sidebar hasn't selected chemistry, for example:
[x] Make sure the other categories select the right subjects, grouped like the subject dashboard. Selecting from the dropdown clears any current selections. Eg, if I was looking at French, then selected Science in the dropdown, only science subjects should become selected, not French+science.
[x] There looks to be a bug that when you select 'all' from the dropdown after selecting some subjects, it makes General and Topical be selected.
@s-steddy it is going to be: Brillder data 25.11.22 12_32.xlsx
@s-steddy All bricks will not load in browser. it will lead to memory leak.
Much improved, but I think the sorting of subjects in the sidebar still isn't quite right. This is what I get when I arrive at the page:
It looks like the subjects in the sidebar are sorted by most bricks or most bricks played, currently it goes from Maths to Sociology, after which it lists the rest of the subjects for which there are no played bricks in alphabetical order. But what I see when I arrive should be alphabetical. Can we just hide the subjects for which there are no bricks played within the selected timeframe?
The sidebar also doesn't change if you select a category group from the dropdown, so, eg. if I select languages I wouldn't expect to see maths at the top of the list:
How about hiding subjects here too which are not within subject category if you select from the dropdown?
Closing this issue now. Future work can be logged separately.
Some comments now this is largely in place:
The way subject selection works needs fine tuning. For one, the text in the dropdown box needs correcting - if you select a category or several subjects they get stringed together and the font goes wrong:
It would make more sense for me to have something like this:
Have categories in the drop-down, along with the 'Everything' option. Have subjects beneath, scrollable, with checkboxes. Subjects are sorted A->Z, but with subjects with bricks first.
Selecting a category from the dropdown selects (ie. fills the checkbox) the related subjects, e.g. choosing 'Languages' from the dropdown would select French, Spanish, Eng Lang etc in the subjects list. User can of course check or uncheck subjects in this list as they go.