Class Invites - remove google sign-in option

Scholar-6 / brillder

Apache License 2.0

3 stars 11 forks source link

Class Invites - remove google sign-in option #4803

Open s-steddy opened 1 year ago

s-steddy commented 1 year ago

Invites to non-existing users, at least, direct to a page allowing signin by email or google. Probably, invites are sent to students' school email addresses - which could in theory be provided by google - but this option is causing confusion.

[x] Invite link should skip this step and just take user to signup page with email + password entry (with email filled as it currently is). We might need to add some explanation on this page.
[ ] After going through signup, ensure user arrives at class page, not general home page.

s-steddy commented 1 year ago

[ ] And a task for me: invite someone who I know uses google to sign in and see what happens (eg. Joe)

ivanromakh commented 1 year ago

after user have activated his account he will go to home page with intro js and then he will see this popup.

ivanromakh commented 1 year ago

after he press accept user will automatically go to assignments page.

ivanromakh commented 1 year ago

user still need to press accept button in order to see class assignments

s-steddy commented 1 year ago

Can see this is working nicely but specifically for invites for new users. Tested by inviting an existing account using google login and was directed to sign in page. The link in the email is this:

https://dev-app.brillder.com/assignments?classroomId=1832

The signin screen was the general one and I had to go to google login specifically - I could've tried with a different account, or gone to sign up even. I couldn't use google login to sign in as there's no brillder password that way.

Unsure how I can even test with the institution user, as we can't see their inbox. Can ask Emma to see notifications email. So, we'll need to keep thinking.