SchoofsKelvin / vscode-sshfs

Extension for Visual Studio Code: File system provider using SSH
GNU General Public License v3.0
543 stars 36 forks source link

V19 UI issue: the disconnect/connect icon is stuck in disconnect (even on disconnected locations) #231

Closed laurencefass closed 3 years ago

laurencefass commented 3 years ago

Version 19.1+ introduces a new LHS column icon for SSFHFS containing locations that was previously available in v18.3 as an accordion dropdown in the main explorer.

Connect/diconnect is broken: it only gives an option to disconnect on locations that not connected. I can open a terminal to the location using v19 UI its the connect/disconnect icon thats broken.

Ive reverted back to v18 which still works fine.

SchoofsKelvin commented 3 years ago

I assume you're talking about those icons? image Hovering your mouse over them explains what they are, which are, from left to right:

The disconnect icon is only meant to disconnect. The disconnect icon is just always displayed (even if it's not connected) for both aesthetic and technical reasons. This is partially because there are 2 ways to connect (workspace folder and/or terminals), so a plain "Connect" button wouldn't make much sense. The extension API doesn't really allow "dynamic icons/buttons" either.

laurencefass commented 3 years ago

looks fine after a restart. thanks.