search

SchoofsKelvin / vscode-sshfs

Extension for Visual Studio Code: File system provider using SSH
GNU General Public License v3.0
543 stars 36 forks source link

Cancel button in the "open file" dialog #305

Closed margrevm closed 2 years ago

margrevm commented 2 years ago

It would be nice to have a "cancel" or "X" button in the "open file" dialog to close this dialog again if clicked by default.

My current workaround is to click to open the "local file" dialog and cancel it in this window.

SchoofsKelvin commented 2 years ago

Which open dialog do you mean? The extension itself doesn't have a file dialog, it uses VS Code's Extension API for that, so you might have to make this feature request on their side.

margrevm commented 2 years ago

Sorry if my ticket was not clear. It is the "Open file" dialog which is opened while having a sshfs in the workspace (File -> Open file...).

Screenshot 2021-10-28 091153

SchoofsKelvin commented 2 years ago

That's something built-in into VS Code. If you use their Remote SSH, Remote - WSL or any other extension that uses the remote menu (the little green button on the bottom-left), when your (I think first) workspace folder is a remote folder (e.g. not file:// or /some/local/path or C:/some/local/path), they replace the open dialog with that variant.

You're probably best off making a feature request on their issues page, assuming there isn't one for this already. or if you're up for a challenge and got some of the necessary knowledge/time, even make a pull request to add such a button