search

SchoofsKelvin / vscode-sshfs

Extension for Visual Studio Code: File system provider using SSH
GNU General Public License v3.0
543 stars 36 forks source link

Correcting github workflow build script #374

Closed hamad12a closed 1 year ago

hamad12a commented 1 year ago

I am unaware of how to ignore the rest commits except this one 302aca0

SchoofsKelvin commented 1 year ago

What exactly is this pull request supposed to accomplish? It looks to me like you want it to make a release (those found here) on every commit instead of only when there's a tag_version, i.e. if the workflow got started by pushing a semver tag.

hamad12a commented 1 year ago

You are right! I missed the point on how to create a release when there is a tag_version. I will cancel this pull request. I tried to create a new tag version on GitHub along with creating new release then running the build script on GitHub actions as a result it ignores to release the binary file on the release page. ---- Kelvin Schoofs wrote ----

What exactly is this pull request supposed to accomplish? It looks to me like you want it to make a release (those found herehttps://github.com/SchoofsKelvin/vscode-sshfs/releases) on every commit instead of only when there's a tag_version, i.e. if the workflow got started by pushing a semver taghttps://github.com/SchoofsKelvin/event-utilities/blob/d60695b4be66794fbe0be55ddfc576e8819a999e/src/index.ts#L24-L28.

— Reply to this email directly, view it on GitHubhttps://github.com/SchoofsKelvin/vscode-sshfs/pull/374#issuecomment-1485843539, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6O7HVAESX3BHK6ZG66AL3W6H4SHANCNFSM6AAAAAAWJKIBSU. You are receiving this because you authored the thread.Message ID: @.***>