SchoofsKelvin / vscode-sshfs

Extension for Visual Studio Code: File system provider using SSH
GNU General Public License v3.0
543 stars 36 forks source link

Fails to save file #376

Open lairdrt opened 1 year ago

lairdrt commented 1 year ago

Type: Bug

Something has changed in the last 1-2 weeks that is causing file saves (to Linux FS) to either take an extended period of time (30+ seconds) or to fail altogether. I have all extensions removed except SSH-FS. This is occurring on multiple, different remote hosts.

Extension version: 1.26.0 VS Code version: Code 1.77.0 (7f329fe6c66b0f86ae1574c2911b681ad5a45d63, 2023-03-29T10:02:16.981Z) OS version: Windows_NT x64 10.0.19045 Modes: Sandboxed: Yes

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-5500U CPU @ 2.40GHz (4 x 2394)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: unavailable_off
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off| |Load (avg)|undefined| |Memory (System)|15.92GB (9.27GB free)| |Process Argv|--crash-reporter-id 32170359-0eeb-401e-bbde-b38577b747df| |Screen Reader|no| |VM|0%|
A/B Experiments ``` vsliv368:30146709 vsreu685:30147344 python383cf:30185419 vspor879:30202332 vspor708:30202333 vspor363:30204092 vswsl492cf:30256860 vslsvsres303:30308271 vserr242:30382549 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vshan820:30294714 vstes263cf:30335440 pythondataviewer:30285071 vscod805:30301674 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 cmake_vspar411:30581797 vsaa593cf:30376535 pythonvs932:30410667 cppdebug:30492333 vsclangdc:30486549 c4g48928:30535728 dsvsc012:30540252 pynewext54:30695312 azure-dev_surveyone:30548225 nodejswelcome1:30587005 2e4cg342:30602488 pyind779:30671433 89544117:30613380 pythonsymbol12:30671437 a9j8j154:30646983 vsctsb:30677850 pythonb192cf:30669361 functionswalk:30687959 pythonms35:30701012 ```
SchoofsKelvin commented 1 year ago

What OSes and OpenSSH versions (or similar) are you connecting to? Anything related in server side logs?

Last week (March 25) version 1.26.0 of the extension got published. If the issue only started happening since that version, you could try using version 1.25.0 and verify whether it's actually caused by that upgrade (instead of a VS Code update or something obscure).

This issue might be easier to solve with debug logs, so please follow these steps:

lairdrt commented 1 year ago

Thank you for prompt response.

Local OS: OS Name Microsoft Windows 10 Pro Version 10.0.19045 Build 19045 Other OS Description Not Available OS Manufacturer Microsoft Corporation System Manufacturer Dell Inc. System Model Inspiron 17 7000 Series 7746 System Type x64-based PC System SKU Inspiron 17 7000 Series 7746 Processor Intel(R) Core(TM) i7-5500U CPU @ 2.40GHz, 2401 Mhz, 2 Core(s), 4 Logical Processor(s) BIOS Version/Date Dell Inc. A04, 3/25/2015

Remote OS: NAME="Ubuntu" VERSION="20.04.6 LTS (Focal Fossa)" ID=ubuntu ID_LIKE=debian PRETTY_NAME="Ubuntu 20.04.6 LTS" VERSION_ID="20.04" HOME_URL="https://www.ubuntu.com/" SUPPORT_URL="https://help.ubuntu.com/" BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" VERSION_CODENAME=focal UBUNTU_CODENAME=focal

OpenSSH: OpenSSH_8.2p1 Ubuntu-4ubuntu0.5, OpenSSL 1.1.1f 31 Mar 2020

Installed SSH FS v1.25.0 and the problem remains. Perhaps a VSC issue (there was an update "recently").

VSC: Version: 1.77.0 (user setup) Commit: 7f329fe6c66b0f86ae1574c2911b681ad5a45d63 Date: 2023-03-29T10:02:16.981Z Electron: 19.1.11 Chromium: 102.0.5005.196 Node.js: 16.14.2 V8: 10.2.154.26-electron.0 OS: Windows_NT x64 10.0.19045 Sandboxed: Yes

Will try debug logs/logging...

CNDRD commented 1 year ago

Here to add my two cents..

I have the same problem. Saving never visibly failed though, it just took forever after VSCode was up and running for a few minutes (anywhere from 5 to 20 minutes).

SSH FS version 1.25.0, still the same

Finally I downgraded my VSCode, and that was the magic touch.. Everything is running smoothly on VSCode 1.62.2 (didn't see a difference on either SSH FS versions - 1.25.0/1.26.0)

SchoofsKelvin commented 1 year ago

I'll try if I can reproduce it with VS Code 1.77.0 by keeping it open (minimized without any window focuses) for half an hour. Might be a timeout issue where in the past VS Code would periodically (without any user input like window focuses or explorer refreshes) read things on the remote filesystem while now it does nothing. although the underlying ssh2 library should prevent idle timeouts from happening.

SchoofsKelvin commented 1 year ago

Wasn't able to reproduce it it seems. If you're still experiencing this issue:

james-at-klik commented 1 year ago

I can also report a similar issue since upgrading to VS Code 1.77. It seems to take longer and longer to read the remote files, then eventually it becomes completely unresponsive.

VS Code: 1.77.3 SSH FS: v1.26.0 MacOS: 11.4

Edit 1: downgrading to VS Code 1.75 works for me.

Edit 2: I downgraded and upgraded VS Code back to 1.77 and now I can't replicate the issue...

Edit 3: The issue is occurring again a few days later. I'll try and see if anything appears in the logs.

SchoofsKelvin commented 1 year ago

Can anyone else still replicate this issue? Looks like it was probably caused by a VS Code update which they might've already fixed, but it's still unclear.

james-at-klik commented 1 year ago

log_dump.txt

Here are some log snippets that were recorded while the issue was occurring. "..." indicates gaps between snippets.