search

Schottkyc137 / ginko

A device-tree source parser, analyzer and language server.
MIT License
15 stars 5 forks source link

Add automatic builds for `x86_64-pc-windows-gnu` target #14

Closed ColinFinck closed 2 months ago

ColinFinck commented 3 months ago

I'd like to have fully self-contained ginko/ginko_ls binaries. The currently available binaries created for the x86_64-pc-windows-msvc target depend on the VCRUNTIME140.DLL file. This file doesn't come with Windows. You're also not supposed to redistribute it along with your application. The only official way to get that DLL is to launch the installer of the Visual C++ redistributable package.

An alternative is building ginko/ginko_ls for the x86_64-pc-windows-gnu target. Binaries created for that target are a little larger, but only depend on Windows system libraries. No extra DLL needs to be installed/redistributed and the resulting binaries can be used on any fresh Windows installation.

My PR adds that target to GitHub Actions. Would love to see it in the next release :)

Schottkyc137 commented 2 months ago

LGTM, thanks for the contribution!