Schottkyc137 / ginko

A device-tree source parser, analyzer and language server.
MIT License
15 stars 5 forks source link

Let unknown file endings through as FileType::Unknown #15

Closed monkeydom closed 1 month ago

monkeydom commented 1 month ago

This allows for the client to feed in additional custom extensions. The spec only goes for "Should" in all of its extension naming conventions, so trying to analyze files with extensions configured in the language client but unknown to the library should not be blocked at this stage.

monkeydom commented 1 month ago

For more background: I do want to use custom extensions for some of top level DeviceTree filenames and attach some meaning to it, and with the current behavior this is prevented.

Schottkyc137 commented 1 month ago

Seeing that you are already the second person to request this change, I think it's reasonable to assume that device-tree endings aren't as unified as I thought. Maybe one could even think about a configuration option that would be passed from the client to the server for custom device-tree endings to associate them to the correct file type so that the server can correctly analyze them.